Re: [RFC PATCH] iommu/vt-d: Fix IOMMU field not populated on device hot re-plug

2019-08-27 Thread Lu Baolu
Hi Janusz, On 8/27/19 5:35 PM, Janusz Krzysztofik wrote: Hi Lu, On Monday, August 26, 2019 10:29:12 AM CEST Lu Baolu wrote: Hi Janusz, On 8/26/19 4:15 PM, Janusz Krzysztofik wrote: Hi Lu, On Friday, August 23, 2019 3:51:11 AM CEST Lu Baolu wrote: Hi, On 8/22/19 10:29 PM, Janusz

Re: [PATCH] vmd: Stop overriding dma_map_ops

2019-08-27 Thread Keith Busch
On Tue, Aug 27, 2019 at 11:24:05AM -0700, Derrick, Jonathan wrote: > On Mon, 2019-08-26 at 17:06 +0200, Christoph Hellwig wrote: > > With a little tweak to the intel-iommu code we should be able to work > > around the VMD mess for the requester IDs without having to create giant > > amounts of

Re: [PATCH] vmd: Stop overriding dma_map_ops

2019-08-27 Thread Derrick, Jonathan
On Mon, 2019-08-26 at 17:06 +0200, Christoph Hellwig wrote: > With a little tweak to the intel-iommu code we should be able to work > around the VMD mess for the requester IDs without having to create giant > amounts of boilerplate DMA ops wrapping code. The other advantage of > this scheme is

Re: [PATCH 2/7] dt-bindings: arm-smmu: Add Adreno GPU variant

2019-08-27 Thread Rob Herring
On Tue, 20 Aug 2019 13:06:27 -0600, Jordan Crouse wrote: > Add a compatible string to identify SMMUs that are attached > to Adreno GPU devices that wish to support split pagetables. > > Signed-off-by: Jordan Crouse > --- > > Documentation/devicetree/bindings/iommu/arm,smmu.txt | 7 +++ > 1

Re: [PATCH 2/2] ARM: OMAP2+: Add pdata for OMAP3 ISP IOMMU

2019-08-27 Thread kbuild test robot
Hi Suman, Thank you for the patch! Yet something to improve: [auto build test ERROR on arm/for-next] [cannot apply to v5.3-rc6 next-20190827] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [PATCH v2 2/2] dma-contiguous: Use fallback alloc_pages for single pages

2019-08-27 Thread Christoph Hellwig
On Tue, Aug 27, 2019 at 06:03:14PM +0900, Masahiro Yamada wrote: > Yes, this makes my driver working again > when CONFIG_DMA_CMA=y. > > > If I apply the following, my driver gets back working > irrespective of CONFIG_DMA_CMA. That sounds a lot like the device simply isn't 64-bit DMA capable,

Re: [PATCH 1/2] ARM: OMAP2+: Plug in device_enable/idle ops for IOMMUs

2019-08-27 Thread kbuild test robot
/Suman-Anna/OMAP-IOMMU-fixes-to-go-with-5-4-OMAP-IOMMU-changes/20190827-121217 base: git://git.armlinux.org.uk/~rmk/linux-arm.git for-next config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp

Re: [PATCH 6/6] MIPS: document mixing "slightly different CCAs"

2019-08-27 Thread Paul Burton
Hi Christoph, On Mon, Aug 26, 2019 at 03:25:53PM +0200, Christoph Hellwig wrote: > Based on an email from Paul Burton, quoting section 4.8 "Cacheability and > Coherency Attributes and Access Types" of "MIPS Architecture Volume 1: > Introduction to the MIPS32 Architecture" (MD00080, revision

Re: [PATCH 3/6] dma-mapping: remove arch_dma_mmap_pgprot

2019-08-27 Thread Paul Burton
Hi Christoph, On Mon, Aug 26, 2019 at 03:25:50PM +0200, Christoph Hellwig wrote: > arch_dma_mmap_pgprot is used for two things: > > 1) to override the "normal" uncached page attributes for mapping > memory coherent to devices that can't snoop the CPU caches > 2) to provide the special

Re: [RFC PATCH] iommu/vt-d: Fix IOMMU field not populated on device hot re-plug

2019-08-27 Thread Janusz Krzysztofik
Hi Lu, On Monday, August 26, 2019 10:29:12 AM CEST Lu Baolu wrote: > Hi Janusz, > > On 8/26/19 4:15 PM, Janusz Krzysztofik wrote: > > Hi Lu, > > > > On Friday, August 23, 2019 3:51:11 AM CEST Lu Baolu wrote: > >> Hi, > >> > >> On 8/22/19 10:29 PM, Janusz Krzysztofik wrote: > >>> When a

Re: [PATCH v2 2/2] dma-contiguous: Use fallback alloc_pages for single pages

2019-08-27 Thread Masahiro Yamada
On Tue, Aug 27, 2019 at 4:50 PM Christoph Hellwig wrote: > > On Tue, Aug 27, 2019 at 04:45:20PM +0900, Masahiro Yamada wrote: > > On Mon, Aug 26, 2019 at 4:33 PM Christoph Hellwig wrote: > > > > > > On Mon, Aug 26, 2019 at 11:05:00AM +0900, Masahiro Yamada wrote: > > > > This is included in

Re: [PATCH v2 2/2] dma-contiguous: Use fallback alloc_pages for single pages

2019-08-27 Thread Christoph Hellwig
On Tue, Aug 27, 2019 at 04:45:20PM +0900, Masahiro Yamada wrote: > On Mon, Aug 26, 2019 at 4:33 PM Christoph Hellwig wrote: > > > > On Mon, Aug 26, 2019 at 11:05:00AM +0900, Masahiro Yamada wrote: > > > This is included in v5.3-rc6 > > > so I tested it. > > > > So there is no allocation failure,

Re: [PATCH v2 2/2] dma-contiguous: Use fallback alloc_pages for single pages

2019-08-27 Thread Masahiro Yamada
On Mon, Aug 26, 2019 at 4:33 PM Christoph Hellwig wrote: > > On Mon, Aug 26, 2019 at 11:05:00AM +0900, Masahiro Yamada wrote: > > This is included in v5.3-rc6 > > so I tested it. > > So there is no allocation failure, but you get I/O errors later? Right. > > Does the device use a device-private

Re: [PATCH v2 10/11] arm64: edit zone_dma_bits to fine tune dma-direct min mask

2019-08-27 Thread Petr Tesarik
On Mon, 26 Aug 2019 13:08:50 +0200 Nicolas Saenz Julienne wrote: > On Mon, 2019-08-26 at 09:06 +0200, Christoph Hellwig wrote: > > On Tue, Aug 20, 2019 at 04:58:18PM +0200, Nicolas Saenz Julienne wrote: > > > - if (IS_ENABLED(CONFIG_ZONE_DMA)) > > > + if (IS_ENABLED(CONFIG_ZONE_DMA)) { > > >

Re: [PATCH 03/11] xen/arm: simplify dma_cache_maint

2019-08-27 Thread Christoph Hellwig
And this was still buggy I think, it really needs some real Xen/Arm testing which I can't do. Hopefully better version below: -- >From 5ad4b6e291dbb49f65480c9b769414931cbd485a Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Wed, 24 Jul 2019 15:26:08 +0200 Subject: xen/arm: simplify

Re: swiotlb-xen cleanups

2019-08-27 Thread Christoph Hellwig
On Mon, Aug 26, 2019 at 07:00:44PM -0700, Stefano Stabellini wrote: > On Fri, 16 Aug 2019, Christoph Hellwig wrote: > > Hi Xen maintainers and friends, > > > > please take a look at this series that cleans up the parts of swiotlb-xen > > that deal with non-coherent caches. > > Hi Christoph, > >