RE: [PATCH v11 05/10] iommu/vt-d: Add bind guest PASID support

2020-04-17 Thread Tian, Kevin
> From: Jacob Pan > Sent: Friday, April 17, 2020 11:29 PM > > On Fri, 17 Apr 2020 09:46:55 +0200 > Auger Eric wrote: > > > Hi Kevin, > > On 4/17/20 4:45 AM, Tian, Kevin wrote: > > >> From: Auger Eric > > >> Sent: Thursday, April 16, 2020 6:43 PM > > >> > > > [...] > > > + if (svm) { > >

Re: [patch 0/7] unencrypted atomic DMA pools with dynamic expansion

2020-04-17 Thread David Rientjes via iommu
On Fri, 17 Apr 2020, Christoph Hellwig wrote: > So modulo a few comments that I can fix up myself this looks good. Unless > you want to resend for some reason I'm ready to pick this up once I open > the dma-mapping tree after -rc2. > Yes, please do, and thanks to both you and Thomas for the gui

Re: [PATCH v11 07/10] iommu/vt-d: Add svm/sva invalidate function

2020-04-17 Thread Jacob Pan
On Thu, 16 Apr 2020 12:59:14 +0200 Auger Eric wrote: > Hi Jacob, > On 4/10/20 11:56 PM, Jacob Pan wrote: > > On Thu, 9 Apr 2020 10:50:34 +0200 > > Auger Eric wrote: > > > >> Hi Jacob, > >> > >> On 4/3/20 8:42 PM, Jacob Pan wrote: > >>> When Shared Virtual Address (SVA) is enabled for a gues

Re: [PATCH v11 05/10] iommu/vt-d: Add bind guest PASID support

2020-04-17 Thread Jacob Pan
On Fri, 17 Apr 2020 09:46:55 +0200 Auger Eric wrote: > Hi Kevin, > On 4/17/20 4:45 AM, Tian, Kevin wrote: > >> From: Auger Eric > >> Sent: Thursday, April 16, 2020 6:43 PM > >> > > [...] > > + if (svm) { > > + /* > > +* If we found svm for the P

Re: [PATCH v3 1/3] iommu/vt-d: Allow 32bit devices to uses DMA domain

2020-04-17 Thread Lu Baolu
Hi Christoph, On 2020/4/17 14:50, Christoph Hellwig wrote: On Thu, Apr 16, 2020 at 03:40:38PM +0800, Lu Baolu wrote: description. I'd need to look at the final code, but it seems like this will still cause bounce buffering instead of using dynamic mapping, which still seems like an awful idea.

Re: [PATCH v4] dt-bindings: iommu: renesas, ipmmu-vmsa: convert to json-schema

2020-04-17 Thread Geert Uytterhoeven
Hi Shimoda-san, (not related to the json-schema conversion) On Fri, Apr 17, 2020 at 9:03 AM Yoshihiro Shimoda wrote: > + renesas,ipmmu-main: > +$ref: /schemas/types.yaml#/definitions/phandle-array > +description: > + Reference to the main IPMMU instance in two cells. The first cell

Re: [PATCH 1/4] dma-mapping: move the remaining DMA API calls out of line

2020-04-17 Thread Christoph Hellwig
On Wed, Apr 15, 2020 at 09:21:37PM +1000, Alexey Kardashevskiy wrote: > And the fact they were exported leaves possibility that there is a > driver somewhere relying on these symbols or distro kernel won't build > because the symbol disappeared from exports (I do not know what KABI > guarantees or

Re: [PATCH v11 05/10] iommu/vt-d: Add bind guest PASID support

2020-04-17 Thread Auger Eric
Hi Kevin, On 4/17/20 4:45 AM, Tian, Kevin wrote: >> From: Auger Eric >> Sent: Thursday, April 16, 2020 6:43 PM >> > [...] > + if (svm) { > + /* > + * If we found svm for the PASID, there must be at > + * least one device bond, otherwise svm should be >

Re: [PATCH v4] dt-bindings: iommu: renesas, ipmmu-vmsa: convert to json-schema

2020-04-17 Thread Geert Uytterhoeven
On Fri, Apr 17, 2020 at 9:03 AM Yoshihiro Shimoda wrote: > Convert Renesas VMSA-Compatible IOMMU bindings documentation > to json-schema. > > Note that original documentation doesn't mention renesas,ipmmu-vmsa > for R-Mobile APE6. But, R-Mobile APE6 is similar to the R-Car > Gen2. So, renesas,ipmm

[PATCH] dma-debug: make __dma_entry_alloc_check_leak() static

2020-04-17 Thread Jason Yan
Fix the following sparse warning: kernel/dma/debug.c:659:6: warning: symbol '__dma_entry_alloc_check_leak' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: Jason Yan --- kernel/dma/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/d

Re: [PATCH] dma-debug: make __dma_entry_alloc_check_leak() static

2020-04-17 Thread Christoph Hellwig
On Fri, Apr 17, 2020 at 03:36:05PM +0800, Jason Yan wrote: > Fix the following sparse warning: > > kernel/dma/debug.c:659:6: warning: symbol '__dma_entry_alloc_check_leak' > was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Looks good, I'll queue thi

Re: [patch 0/7] unencrypted atomic DMA pools with dynamic expansion

2020-04-17 Thread Christoph Hellwig
So modulo a few comments that I can fix up myself this looks good. Unless you want to resend for some reason I'm ready to pick this up once I open the dma-mapping tree after -rc2. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linu

Re: [patch 5/7] dma-pool: add pool sizes to debugfs

2020-04-17 Thread Christoph Hellwig
On Wed, Apr 15, 2020 at 08:45:08AM -0500, Tom Lendacky wrote: > > > On 4/14/20 7:04 PM, David Rientjes wrote: >> The atomic DMA pools can dynamically expand based on non-blocking >> allocations that need to use it. >> >> Export the sizes of each of these pools, in bytes, through debugfs for >> meas

Re: [patch 4/7] dma-direct: atomic allocations must come from atomic coherent pools

2020-04-17 Thread Christoph Hellwig
The subject should say something like "atomic unencrypted allocations.." as many other atomic allocations are fine. Which brings up that with the codebase in this patch we can't really support architectures that require both an atomic pool for uncached remapping for just some devices and unencry

Re: [patch 1/7] dma-remap: separate DMA atomic pools from direct remap code

2020-04-17 Thread Christoph Hellwig
On Tue, Apr 14, 2020 at 05:04:52PM -0700, David Rientjes wrote: > DMA atomic pools will be needed beyond only CONFIG_DMA_DIRECT_REMAP so > separate them out into their own file. > > This also adds a new Kconfig option that can be subsequently used for > options, such as CONFIG_AMD_MEM_ENCRYPT, tha

[PATCH v4] dt-bindings: iommu: renesas, ipmmu-vmsa: convert to json-schema

2020-04-17 Thread Yoshihiro Shimoda
Convert Renesas VMSA-Compatible IOMMU bindings documentation to json-schema. Note that original documentation doesn't mention renesas,ipmmu-vmsa for R-Mobile APE6. But, R-Mobile APE6 is similar to the R-Car Gen2. So, renesas,ipmmu-r8a73a4 belongs the renesas,ipmmu-vmsa section. Signed-off-by: Yos