Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit

2022-04-24 Thread zhangfei....@foxmail.com
Hi, Dave On 2022/4/12 下午11:35, Dave Hansen wrote: On 4/12/22 08:10, Jean-Philippe Brucker wrote: I wonder if the Intel and ARM IOMMU code differ in the way they keep references to the mm, or if this affects Intel as well, but we just haven't tested the code enough. The Arm code was written

Re: [PATCH] iommu/mediatek: fix NULL pointer dereference when printing dev_name

2022-04-24 Thread Miles Chen via iommu
>Hi Miles, > >Thank you for the patch! Perhaps something to improve: > >[auto build test WARNING on joro-iommu/next] >[also build test WARNING on v5.18-rc3 next-20220422] >[If your patch is applied to the wrong git tree, kindly drop us a note. >And when submitting patch, we suggest to use '--base'

Re: [PATCH 03/25] dma-direct: take dma-ranges/offsets into account in resource mapping

2022-04-24 Thread Serge Semin
On Thu, Apr 21, 2022 at 09:51:31PM +0100, Robin Murphy wrote: > On 2022-04-21 18:35, Serge Semin wrote: > > On Thu, Apr 21, 2022 at 04:45:36PM +0200, Christoph Hellwig wrote: > > > On Wed, Apr 20, 2022 at 11:55:38AM +0300, Serge Semin wrote: > > > > On Wed, Apr 20, 2022 at 10:47:46AM +0200,

Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit

2022-04-24 Thread Zhangfei Gao
Hi, Jean & Fenghua The issue of "iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit" is mm_pasid_drop in __mmput only ioasid_free(mm->pasid), but keep all related resources, like cd tables etc. This introduces many strange issues. For example, if application does not

Re: [PATCH v2 1/4] iommu/vt-d: Check before setting PGSNP bit in pasid table entry

2022-04-24 Thread Lu Baolu
On 2022/4/24 13:55, Tian, Kevin wrote: From: Lu Baolu Sent: Sunday, April 24, 2022 12:38 PM On 2022/4/24 11:37, Tian, Kevin wrote: This should be rebased on top of Jason's enforce coherency series instead of blindly setting it. No matter whether it's legacy mode where we set SNP in PTE or