Re: [PATCH v2 3/9] net: mdio: Delete usage of driver_deferred_probe_check_state()

2022-07-05 Thread Geert Uytterhoeven
if (rc == -EPROBE_DEFER) > - return rc; > + rc = -ENODEV; > > if (rc > 0) { > phy->irq = rc; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond

Re: [PATCH v2 1/9] PM: domains: Delete usage of driver_deferred_probe_check_state()

2022-07-01 Thread Geert Uytterhoeven
t use of simple-pm-bus device? Well, if the hardware is wired that way... It's not that dissimilar from CPU cores, and interrupt and GPIO controllers in power domains and clocked by controllable clocks: you can cut the branch you're sitting on, and you have to be careful when going to sleep, a

Re: [PATCH v2 1/9] PM: domains: Delete usage of driver_deferred_probe_check_state()

2022-07-01 Thread Geert Uytterhoeven
hey > both initialize this device. > > gpc: gpc@303a { > compatible = "fsl,imx8mq-gpc"; > } > > $ git grep -l "fsl,imx7d-gpc" -- drivers/ > drivers/irqchip/irq-imx-gpcv2.c > drivers/soc/imx/gpcv2.c You missed the "driver" i

Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-28 Thread Geert Uytterhoeven
Hi Michael, On Tue, Jun 28, 2022 at 5:26 AM Michael Schmitz wrote: > Am 28.06.2022 um 09:12 schrieb Michael Schmitz: > > On 27/06/22 20:26, Geert Uytterhoeven wrote: > >> On Sat, Jun 18, 2022 at 3:06 AM Michael Schmitz > >> wrote: > >>> Am 18.06.2022 um 0

Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-27 Thread Geert Uytterhoeven
e at all. FTR, the sgiwd93 driver use dma_map_single(). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. Bu

Re: [PATCH] iommu/ipmmu-vmsa: Fix compatible for rcar-gen4

2022-06-17 Thread Geert Uytterhoeven
On Fri, Jun 17, 2022 at 3:16 AM Yoshihiro Shimoda wrote: > Fix compatible string for R-Car Gen4. > > Fixes: ae684caf465b ("iommu/ipmmu-vmsa: Add support for R-Car Gen4") > Signed-off-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

[PATCH v2] dt-bindings: iommu: renesas, ipmmu-vmsa: R-Car V3U is R-Car Gen4

2022-06-10 Thread Geert Uytterhoeven
Despite the name, R-Car V3U is the first member of the R-Car Gen4 family. Hence move its compatible value to the R-Car Gen4 section. Signed-off-by: Geert Uytterhoeven Acked-by: Krzysztof Kozlowski Acked-by: Joerg Roedel Reviewed-by: Wolfram Sang --- v2: - Add Acked-by, Reviewed-by, - Add

Re: [PATCH v2 0/9] deferred_probe_timeout logic clean up

2022-06-08 Thread Geert Uytterhoeven
Hi Saravana, On Wed, Jun 8, 2022 at 8:13 PM Saravana Kannan wrote: > On Wed, Jun 8, 2022 at 3:26 AM Geert Uytterhoeven > wrote: > > On Wed, Jun 8, 2022 at 6:17 AM Saravana Kannan wrote: > > > On Tue, Jun 7, 2022 at 5:55 PM Saravana Kannan > > > wrote: > >

Re: [PATCH v2 0/9] deferred_probe_timeout logic clean up

2022-06-08 Thread Geert Uytterhoeven
Hi Saravana, On Wed, Jun 8, 2022 at 6:17 AM Saravana Kannan wrote: > On Tue, Jun 7, 2022 at 5:55 PM Saravana Kannan wrote: > > On Tue, Jun 7, 2022 at 11:13 AM Geert Uytterhoeven > > wrote: > > > On Wed, Jun 1, 2022 at 12:46 PM Saravana Kannan > > > wr

Re: [PATCH v2 0/9] deferred_probe_timeout logic clean up

2022-06-07 Thread Geert Uytterhoeven
s/devices/platform/soc/e650.i2c/i2c-0/0-0070/video4linux/v4l-subdev2 The i2c device is the adi,adv7482 at address 0x70. But now I'm lost... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@lin

Re: [RFC PATCH v1 8/9] net: ipconfig: Force fw_devlink to unblock any devices that might probe

2022-06-07 Thread Geert Uytterhoeven
ild fails with: net/ipv4/ipconfig.c:1438:2: error: implicit declaration of function ‘fw_devlink_unblock_may_probe’ [-Werror=implicit-function-declaration] Switching to v2 instead... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org I

Re: [PATCH 6/6] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-07 Thread Geert Uytterhoeven
letely. > > Signed-off-by: Arnd Bergmann > arch/m68k/Kconfig | 1 - > arch/m68k/include/asm/virtconvert.h | 4 +- Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeve

Re: [RFC PATCH v1 0/9] deferred_probe_timeout logic clean up

2022-05-30 Thread Geert Uytterhoeven
patches, and the same is true after applying this series on top. Tested-by: Geert Uytterhoeven I will do testing on more boards, but that may take a while, as we're in the middle of the merge window. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond

Re: [RFC PATCH v1 2/9] pinctrl: devicetree: Delete usage of driver_deferred_probe_check_state()

2022-05-30 Thread Geert Uytterhoeven
supplier > has probed successfully or before deferred probe timeout has expired. > > So, delete the call and replace it with -ENODEV. > > Signed-off-by: Saravana Kannan Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...

Re: [RFC PATCH v1 4/9] Revert "driver core: Set default deferred_probe_timeout back to 0."

2022-05-30 Thread Geert Uytterhoeven
cal copy of https://lore.kernel.org/r/20220526034609.480766-3-sarava...@google.com? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But w

[PATCH 3/7] dt-bindings: iommu: renesas, ipmmu-vmsa: R-Car V3U is R-Car Gen4

2022-05-02 Thread Geert Uytterhoeven
Despite the name, R-Car V3U is the first member of the R-Car Gen4 family. Hence move its compatible value to the R-Car Gen4 section. Signed-off-by: Geert Uytterhoeven --- .../devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH 6/7] dt-bindings: serial: renesas, scif: R-Car V3U is R-Car Gen4

2022-05-02 Thread Geert Uytterhoeven
Despite the name, R-Car V3U is the first member of the R-Car Gen4 family. Hence move its compatible value to the R-Car Gen4 section. Signed-off-by: Geert Uytterhoeven --- Documentation/devicetree/bindings/serial/renesas,scif.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 5/7] dt-bindings: serial: renesas, hscif: R-Car V3U is R-Car Gen4

2022-05-02 Thread Geert Uytterhoeven
Despite the name, R-Car V3U is the first member of the R-Car Gen4 family. Hence move its compatible value to the R-Car Gen4 section. Signed-off-by: Geert Uytterhoeven --- Documentation/devicetree/bindings/serial/renesas,hscif.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 7/7] dt-bindings: watchdog: renesas, wdt: R-Car V3U is R-Car Gen4

2022-05-02 Thread Geert Uytterhoeven
Despite the name, R-Car V3U is the first member of the R-Car Gen4 family. Hence move its compatible value to the R-Car Gen4 section. Signed-off-by: Geert Uytterhoeven --- Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 0/7] dt-bindings: renesas: R-Car V3U is R-Car Gen4

2022-05-02 Thread Geert Uytterhoeven
/73cea9d5e1a6639422c67e4df4285042e31c9fd5.1651497071.git.geert+rene...@glider.be [3] [PATCH] soc: renesas: R-Car V3U is R-Car Gen4 https://lore.kernel.org/2bbecad7b6c24c0d5c1797b3f7f0733d5ba33842.1651497066.git.geert+rene...@glider.be Geert Uytterhoeven (7): dt-bindings: gpio: renesas,rcar-gpio: R-Car V3U is R-Car Gen4 dt-bindings: i2c

[PATCH 1/7] dt-bindings: gpio: renesas, rcar-gpio: R-Car V3U is R-Car Gen4

2022-05-02 Thread Geert Uytterhoeven
Despite the name, R-Car V3U is the first member of the R-Car Gen4 family. Hence move its compatible value to the R-Car Gen4 section. Signed-off-by: Geert Uytterhoeven --- Documentation/devicetree/bindings/gpio/renesas,rcar-gpio.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

[PATCH 4/7] dt-bindings: renesas,rcar-dmac: R-Car V3U is R-Car Gen4

2022-05-02 Thread Geert Uytterhoeven
Despite the name, R-Car V3U is the first member of the R-Car Gen4 family. Hence move its compatible value to the R-Car Gen4 section. Signed-off-by: Geert Uytterhoeven --- .../devicetree/bindings/dma/renesas,rcar-dmac.yaml | 10 -- 1 file changed, 4 insertions(+), 6 deletions

[PATCH 2/7] dt-bindings: i2c: renesas, rcar-i2c: R-Car V3U is R-Car Gen4

2022-05-02 Thread Geert Uytterhoeven
section. Signed-off-by: Geert Uytterhoeven --- Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml b/Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml

Re: [PATCH v2 2/2] iommu/ipmmu-vmsa: Add support for R-Car Gen4

2022-02-07 Thread Geert Uytterhoeven
On Fri, Feb 4, 2022 at 4:49 PM Yoshihiro Shimoda wrote: > Add support for R-Car Gen4 like r8a779f0 (R-Car S4-8). The IPMMU > hardware design of r8a779f0 is the same as r8a779a0. So, rename > "r8a779a0" to "rcar_gen4". > > Signed-off-by: Yoshihiro Shimoda R

Re: [PATCH v2 1/2] dt-bindings: iommu: renesas,ipmmu-vmsa: add r8a779f0 support

2022-02-07 Thread Geert Uytterhoeven
On Fri, Feb 4, 2022 at 2:54 PM Yoshihiro Shimoda wrote: > Document the compatible values for the IPMMU-VMSA blocks in > the Renesas R-Car S4-8 (R8A779F0) SoC and R-Car Gen4. > > Signed-off-by: Yoshihiro Shimoda > 3fbefb9570325500dbf3faff80ded6d0d46f48b2 Reviewed-by: Geert Uy

Re: [PATCH 2/2] iommu/ipmmu-vmsa: Add support for R-Car Gen4

2022-02-02 Thread Geert Uytterhoeven
Hi Shimoda-san, On Wed, Feb 2, 2022 at 11:48 AM Yoshihiro Shimoda wrote: > > From: Geert Uytterhoeven, Sent: Wednesday, February 2, 2022 6:24 PM > > On Tue, Jan 25, 2022 at 6:36 PM Yoshihiro Shimoda > > wrote: > > > Add support for R-Car Gen4 like r8a779f0 (R-Car S4-8

Re: [PATCH 1/2] dt-bindings: iommu: renesas, ipmmu-vmsa: add r8a779f0 support

2022-02-02 Thread Geert Uytterhoeven
Hi Shimoda-san, On Fri, Jan 28, 2022 at 1:09 AM Yoshihiro Shimoda wrote: > > From: Geert Uytterhoeven, Sent: Thursday, January 27, 2022 8:06 PM > > > On Tue, Jan 25, 2022 at 6:33 PM Yoshihiro Shimoda > > wrote: > > > Document the compatible values for the IPMMU-VM

Re: [PATCH 2/2] iommu/ipmmu-vmsa: Add support for R-Car Gen4

2022-02-02 Thread Geert Uytterhoeven
to opt-in devices. > +* R-Car Gen3, Gen4 and RZ/G2 use the allow list to opt-in devices. > * For Other SoCs, this returns true anyway. > */ > if (!soc_device_match(soc_needs_opt_in)) There are a few more references to "Gen3" that can be exten

Re: [PATCH 1/2] dt-bindings: iommu: renesas, ipmmu-vmsa: add r8a779f0 support

2022-01-27 Thread Geert Uytterhoeven
we don't have it, and match on (all) the SoC-specific compatible values instead. Do you remember why we decided to do it that way? At least R-Car V3M/V3H/D3 have slight differences in the register bits, but I don't think that was the reason. Gr{oetje,eeting}s, Geert -- Geert

[PATCH] dt-bindings: iommu: renesas, ipmmu-vmsa: Reformat renesas, ipmmu-main description

2022-01-26 Thread Geert Uytterhoeven
Remove trailing whitespace and break overly long lines. Signed-off-by: Geert Uytterhoeven --- .../devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml b

Re: [PATCH] dt-bindings: Improve phandle-array schemas

2022-01-19 Thread Geert Uytterhoeven
ion: 1st arg cell > - description: 2nd arg cell > > With this change, some examples need updating so that the bracketing of > property values matches the schema. > Signed-off-by: Rob Herring The Renesas parts look good to me. Reviewed-by: Geert Uytterhoeven Gr{oetje,

Re: [PATCH 0/2] iommu/ipmmu-vmsa: Add support for r8a779a0

2021-09-30 Thread Geert Uytterhoeven
s to rcar-4.1.0.rc16 of the R-Car BSP, I was pointed to the fact that the IPMMU modules on R-Car V3U have module clocks and resets, unlike on other R-Car SoCs. Probably they should be handled, too? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux be

Re: [PATCH 2/2] iommu/ipmmu-vmsa: Add support for r8a779a0

2021-09-07 Thread Geert Uytterhoeven
Hi Shimoda-san, On Tue, Sep 7, 2021 at 9:29 AM Yoshihiro Shimoda wrote: > > From: Geert Uytterhoeven, Sent: Tuesday, September 7, 2021 3:34 PM > > On Tue, Sep 7, 2021 at 2:02 AM Yoshihiro Shimoda > > wrote: > > > > From: Geert Uytterhoeven, Sent: Tuesd

Re: [PATCH 2/2] iommu/ipmmu-vmsa: Add support for r8a779a0

2021-09-07 Thread Geert Uytterhoeven
Hi Shimoda-san, On Tue, Sep 7, 2021 at 2:02 AM Yoshihiro Shimoda wrote: > > From: Geert Uytterhoeven, Sent: Tuesday, September 7, 2021 12:34 AM > > On Wed, Sep 1, 2021 at 12:27 PM Yoshihiro Shimoda > > wrote: > > > Add support for r8a779a0 (R-Car V3U)

Re: [PATCH 2/2] iommu/ipmmu-vmsa: Add support for r8a779a0

2021-09-06 Thread Geert Uytterhoeven
less, I assume this will still work when when limiting to 8 contexts, so Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a

Re: [PATCH 1/2] dt-bindings: iommu: renesas, ipmmu-vmsa: add r8a779a0 support

2021-09-06 Thread Geert Uytterhoeven
On Wed, Sep 1, 2021 at 12:27 PM Yoshihiro Shimoda wrote: > Add support for r8a779a0 (R-Car V3U). > > Signed-off-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge

Re: [PATCH] iommu/io-pgtable: Abstract iommu_iotlb_gather access

2021-08-24 Thread Geert Uytterhoeven
s fixes the build issues I was seeing. Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking

Re: [PATCH v4 15/24] iommu/io-pgtable: Remove non-strict quirk

2021-08-24 Thread Geert Uytterhoeven
MU_IO_PGTABLE_ARMV7S and IOMMU_IO_PGTABLE_LPAE? Or iommu_iotlb_gather.queued should not be accessed here, or the access wrapped into a static inline helper function with a dummy for the CONFIG_IOMMU_API=n case? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeve

[PATCH] iommu: APPLE_DART should depend on ARCH_APPLE

2021-08-10 Thread Geert Uytterhoeven
iommu/dart: Add DART iommu driver") Signed-off-by: Geert Uytterhoeven --- drivers/iommu/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig index dfe81da483e9e073..e908b8222e4ed679 100644 --- a/drivers/iommu/Kconfig +++ b/dri

Re: [PATCH] dt-bindings: Drop redundant minItems/maxItems

2021-06-22 Thread Geert Uytterhoeven
er of clock-names may not match the order of the clock descriptions. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I

Re: [PATCH 3/3] lib/vsprintf: Use pr_crit() instead of long fancy messages

2021-05-17 Thread Geert Uytterhoeven
On Wed, Mar 31, 2021 at 11:59 AM Geert Uytterhoeven wrote: > While long fancy messages have a higher probability of being seen than > small messages, they may scroll of the screen fast, if visible at all, > and may still be missed. In addition, they increase boot time and >

Re: [RFC v1 PATCH 3/3] driver: update all the code that use soc_device_match

2021-04-19 Thread Geert Uytterhoeven
ed on multiple platforms, some of them registering an SoC device, some of them not registering an SoC device. So there is no way to know the difference between "SoC device not registered, intentionally", and "SoC device not yet registered". soc_device_match() should only be

Re: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match returning -EPROBE_DEFER

2021-04-19 Thread Geert Uytterhoeven
_type.p && !early_soc_dev_attr) > + return ERR_PTR(-EPROBE_DEFER); > + > while (!ret) { > if (!(matches->machine || matches->family || > matches->revision || matches->soc_id)) Gr{oetje,eeting}s,

Re: [PATCH 2/3] tracing: Use pr_crit() instead of long fancy messages

2021-04-01 Thread Geert Uytterhoeven
Hi Steven, On Wed, Mar 31, 2021 at 3:40 PM Steven Rostedt wrote: > On Wed, 31 Mar 2021 11:31:03 +0200 > Geert Uytterhoeven wrote: > > > This reduces kernel size by ca. 0.5 KiB. > > If you are worried about size, disable tracing and it will go away > entirely. 0.5KiB

[PATCH 1/3] iommu: Use pr_crit() instead of long fancy messages

2021-03-31 Thread Geert Uytterhoeven
KERN_WARNING to KERN_CRIT, and removing irrelevant text and graphics. This reduces kernel size by ca. 0.5 KiB. Fixes: bad614b24293ae46 ("iommu: Enable debugfs exposure of IOMMU driver internals") Signed-off-by: Geert Uytterhoeven --- drivers/iommu/iommu-debugfs.c | 19 -

[PATCH 2/3] tracing: Use pr_crit() instead of long fancy messages

2021-03-31 Thread Geert Uytterhoeven
KERN_WARNING to KERN_CRIT, and removing irrelevant text and graphics. This reduces kernel size by ca. 0.5 KiB. Fixes: 2184db46e425c2b8 ("tracing: Print nasty banner when trace_printk() is in use") Signed-off-by: Geert Uytterhoeven --- kernel/trace/trace.c | 17 +++-- 1 file

[PATCH 3/3] lib/vsprintf: Use pr_crit() instead of long fancy messages

2021-03-31 Thread Geert Uytterhoeven
KERN_WARNING to KERN_CRIT, and removing irrelevant text and graphics. This reduces kernel size by ca. 0.5 KiB. Fixes: 5ead723a20e0447b ("lib/vsprintf: no_hash_pointers prints all addresses as unhashed") Signed-off-by: Geert Uytterhoeven --- lib/vsprintf.c | 17 +++-- 1 file

[PATCH 0/3] Use pr_crit() instead of long fancy messages

2021-03-31 Thread Geert Uytterhoeven
level of such messages from KERN_WARNING to KERN_CRIT, and removes irrelevant text and graphics. It was made against linux-next, but applies to v5.12-rc5 with an offset for the last patch. Each of these patches reduces kernel size by ca. 0.5 KiB. Thanks for your comments! Geert Uytterhoeven (3

[PATCH] clk: Align provider-specific CLK_* bit definitions

2021-03-31 Thread Geert Uytterhoeven
at 40 columns, to increase uniformity. Signed-off-by: Geert Uytterhoeven --- include/linux/clk-provider.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h index 58f6fe866ae9b797..8f37829565f9640e 100644

Re: [PATCH v4 4/8] of: property: Add fw_devlink support for optional properties

2021-02-10 Thread Geert Uytterhoeven
; they just use the DMA API, which is the same regardless of an IOMMU being used or not. While for GPIO/IRQ/CLK/DMA/... have request/get_{gpio,irq,clk,dma,...} APIs for a driver to get a reference, which can return -EPROBE_DEFER, no such thing exists for IOMMUs. This is handled by the IOMMU core instead.

Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas

2021-02-03 Thread Geert Uytterhoeven
Hi Rob, On Wed, Feb 3, 2021 at 4:55 PM Rob Herring wrote: > On Wed, Feb 03, 2021 at 09:01:23AM +0100, Geert Uytterhoeven wrote: > > On Tue, Feb 2, 2021 at 9:55 PM Rob Herring wrote: > > > Properties in if/then schemas weren't getting checked by the meta-schemas. > >

Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas

2021-02-03 Thread Geert Uytterhoeven
-r8a73a4 > - - renesas,pfc-r8a7740 > - - renesas,pfc-sh73a0 > + enum: > +- renesas,pfc-r8a73a4 > +- renesas,pfc-r8a7740 > + - renesas,pfc-sh73a0 Missing "contains"? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeve

Re: iommu/vt-d: Cure VF irqdomain hickup

2020-11-16 Thread Geert Uytterhoeven
nline void vf_inherit_msi_domain(struct pci_dev *pdev) > +{ > + dev_set_msi_domain(>dev, > dev_get_msi_domain(>physfn->dev)); If CONFIG_PCI_ATS is not set: error: 'struct pci_dev' has no member named 'physfn' http://kisskb.ellerman.id.au/kisskb/buildresult/14400927/

Re: [GIT PULL] dma-mapping fix for 5.10

2020-11-02 Thread Geert Uytterhoeven
Hi Linus, On Sat, Oct 31, 2020 at 8:51 PM Linus Torvalds wrote: > On Sat, Oct 31, 2020 at 2:40 AM Christoph Hellwig wrote: > > dma-mapping fix for 5.10: > > > > - fix an integer overflow on 32-bit platforms in the new DMA range code > >(Geert Uytterhoeven) >

Re: [PATCH] iommu: Kconfig: Update help description for IPMMU_VMSA config

2020-09-14 Thread Geert Uytterhoeven
-off-by: Lad Prabhakar > Reviewed-by: Chris Paterson Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacke

Re: [PATCH 2/2] ARM: dts: r8a7742: Add IPMMU DT nodes

2020-09-03 Thread Geert Uytterhoeven
On Tue, Aug 25, 2020 at 4:19 PM Lad Prabhakar wrote: > Add the five IPMMU instances found in the r8a7742 to DT with a disabled > status. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Chris Paterson Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-devel for v5.10.

Re: [PATCH 1/2] dt-bindings: iommu: renesas, ipmmu-vmsa: Add r8a7742 support

2020-09-03 Thread Geert Uytterhoeven
On Tue, Aug 25, 2020 at 4:19 PM Lad Prabhakar wrote: > Document RZ/G1H (R8A7742) SoC bindings. > > No driver change is needed due to the fallback compatible value > "renesas,ipmmu-vmsa". > > Signed-off-by: Lad Prabhakar > Reviewed-by: Chris Paterson Reviewed-by

Re: [PATCH] dt-bindings: iommu: renesas,ipmmu-vmsa: Sort compatible string in increasing number of the SoC

2020-08-10 Thread Geert Uytterhoeven
On Sun, Aug 9, 2020 at 9:35 PM Lad Prabhakar wrote: > Sort the items in the compatible string list in increasing number of SoC. > > Signed-off-by: Lad Prabhakar As my previous tag was conditional on fixing the sort order: Reviewed-by: Geert Uytterhoeven Gr{oetje

Re: [PATCH 9/9] arm64: dts: renesas: r8a774e1: Add Ethernet AVB node

2020-07-15 Thread Geert Uytterhoeven
On Mon, Jul 13, 2020 at 11:36 PM Lad Prabhakar wrote: > From: Marian-Cristian Rotariu > > This patch adds the SoC specific part of the Ethernet AVB > device tree node. > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytte

Re: [PATCH 7/9] arm64: dts: renesas: r8a774e1: Add GPIO device nodes

2020-07-15 Thread Geert Uytterhoeven
On Mon, Jul 13, 2020 at 11:35 PM Lad Prabhakar wrote: > From: Marian-Cristian Rotariu > > Add GPIO device nodes to the DT of the r8a774e1 SoC. > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven i.e. will q

Re: [PATCH 5/9] arm64: dts: renesas: r8a774e1: Add SYS-DMAC device nodes

2020-07-15 Thread Geert Uytterhoeven
On Mon, Jul 13, 2020 at 11:35 PM Lad Prabhakar wrote: > From: Marian-Cristian Rotariu > > Add sys-dmac[0-2] device nodes for RZ/G2H (R8A774E1) SoC. > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven i.e. will q

Re: [PATCH 3/9] arm64: dts: renesas: r8a774e1: Add IPMMU device nodes

2020-07-15 Thread Geert Uytterhoeven
On Mon, Jul 13, 2020 at 11:35 PM Lad Prabhakar wrote: > From: Marian-Cristian Rotariu > > Add RZ/G2H (R8A774E1) IPMMU nodes. > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-deve

Re: [PATCH 2/2] iommu/ipmmu-vmsa: Add an entry for r8a77961 in soc_rcar_gen3[]

2020-07-15 Thread Geert Uytterhoeven
On Tue, Jul 14, 2020 at 12:21 PM Lad Prabhakar wrote: > Add an entry for r8a77961 in soc_rcar_gen3[] list so that we dont > enable iommu unconditionally. > > Fixes: 17fe161816398 ("iommu/renesas: Add support for r8a77961") > Signed-off-by: Lad Prabhakar Reviewed-by

Re: [PATCH 1/2] iommu/ipmmu-vmsa: Hook up R8A774E1 DT matching code

2020-07-15 Thread Geert Uytterhoeven
On Tue, Jul 14, 2020 at 12:21 PM Lad Prabhakar wrote: > From: Marian-Cristian Rotariu > > Add support for RZ/G2H (R8A774E1) SoC IPMMUs. > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeve

Re: [PATCH 2/9] iommu/ipmmu-vmsa: Hook up R8A774E1 DT matching code

2020-07-14 Thread Geert Uytterhoeven
Hi Shimoda-san, On Tue, Jul 14, 2020 at 1:42 PM Yoshihiro Shimoda wrote: > > From: Geert Uytterhoeven, Sent: Tuesday, July 14, 2020 5:42 PM > > On Tue, Jul 14, 2020 at 10:30 AM Lad, Prabhakar > > wrote: > > > On Tue, Jul 14, 2020 at 9:09 AM Geert Uytterhoeven >

Re: [PATCH 2/9] iommu/ipmmu-vmsa: Hook up R8A774E1 DT matching code

2020-07-14 Thread Geert Uytterhoeven
Hi Prabhakar, On Tue, Jul 14, 2020 at 10:30 AM Lad, Prabhakar wrote: > On Tue, Jul 14, 2020 at 9:09 AM Geert Uytterhoeven > wrote: > > On Mon, Jul 13, 2020 at 11:35 PM Lad Prabhakar > > wrote: > > > From: Marian-Cristian Rotariu > > > > > >

Re: [PATCH 2/9] iommu/ipmmu-vmsa: Hook up R8A774E1 DT matching code

2020-07-14 Thread Geert Uytterhoeven
data = _features_rcar_gen3, > + }, { > + .compatible = "renesas,ipmmu-r8a774e1", > + .data = _features_rcar_gen3, > }, { > .compatible = "renesas,ipmmu-r8a7795", > .data = _features_rcar_gen3, Gr{oetje,eeting}s,

Re: [PATCH 8/9] dt-bindings: net: renesas,ravb: Add support for r8a774e1 SoC

2020-07-14 Thread Geert Uytterhoeven
On Mon, Jul 13, 2020 at 11:36 PM Lad Prabhakar wrote: > From: Marian-Cristian Rotariu > > Document RZ/G2H (R8A774E1) SoC bindings. > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH 6/9] dt-bindings: gpio: renesas, rcar-gpio: Add r8a774e1 support

2020-07-14 Thread Geert Uytterhoeven
On Mon, Jul 13, 2020 at 11:35 PM Lad Prabhakar wrote: > Document Renesas RZ/G2H (R8A774E1) GPIO blocks compatibility within the > relevant dt-bindings. > > Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert

Re: [PATCH 4/9] dt-bindings: dma: renesas,rcar-dmac: Document R8A774E1 bindings

2020-07-14 Thread Geert Uytterhoeven
On Mon, Jul 13, 2020 at 11:35 PM Lad Prabhakar wrote: > Renesas RZ/G2H (R8A774E1) SoC also has the R-Car gen3 compatible > DMA controllers, therefore document RZ/G2H specific bindings. > > Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven Gr{oe

Re: [PATCH 1/9] dt-bindings: iommu: renesas, ipmmu-vmsa: Add r8a774e1 support

2020-07-14 Thread Geert Uytterhoeven
8a774c0 # RZ/G2E Please preserve alphabetical sort order. >- renesas,ipmmu-r8a7795 # R-Car H3 >- renesas,ipmmu-r8a7796 # R-Car M3-W With the above fixed: Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven --

[PATCH] iommu: SUN50I_IOMMU should depend on HAS_DMA

2020-06-29 Thread Geert Uytterhoeven
: 4100b8c229b32835 ("iommu: Add Allwinner H6 IOMMU driver") Signed-off-by: Geert Uytterhoeven --- drivers/iommu/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig index 6dc49ed8377a5c12..b0f308cb7f7c2fc2 100644 --- a/drivers/iommu/Kco

Re: [PATCH v2] dma-pool: Fix too large DMA pools on medium systems

2020-06-21 Thread Geert Uytterhoeven
Hi Günter, On Sat, Jun 20, 2020 at 10:09 PM Guenter Roeck wrote: > On Mon, Jun 08, 2020 at 03:22:17PM +0200, Geert Uytterhoeven wrote: > > On systems with at least 32 MiB, but less than 32 GiB of RAM, the DMA > > memory pools are much larger than intended (e.g. 2 MiB instead

Re: [PATCH 1/2] dt-bindings: iommu: renesas, ipmmu-vmsa: add r8a77961 support

2020-06-18 Thread Geert Uytterhoeven
On Thu, Jun 11, 2020 at 1:11 PM Yoshihiro Shimoda wrote: > Add support for r8a77961 (R-Car M3-W+). > > Signed-off-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge

[PATCH v2] dma-pool: Fix too large DMA pools on medium systems

2020-06-08 Thread Geert Uytterhoeven
, to keep on calculating in pages until the last step, which aids readability. Fixes: 1d659236fb43c4d2 ("dma-pool: scale the default DMA coherent pool size with memory capacity") Signed-off-by: Geert Uytterhoeven --- v2: - Improve readability: - Divide by (SZ_1G / SZ_128K) instea

Re: [PATCH] dma-pool: Fix too large DMA pools on medium systems

2020-06-08 Thread Geert Uytterhoeven
Hi Robin, On Mon, Jun 8, 2020 at 2:04 PM Robin Murphy wrote: > On 2020-06-08 09:52, Geert Uytterhoeven wrote: > > On systems with at least 32 MiB, but less than 32 GiB of RAM, the DMA > > memory pools are much larger than intended (e.g. 2 MiB instead of 128 > > Ki

[PATCH] dma-pool: Fix too large DMA pools on medium systems

2020-06-08 Thread Geert Uytterhoeven
scale the default DMA coherent pool size with memory capacity") Signed-off-by: Geert Uytterhoeven --- kernel/dma/pool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/dma/pool.c b/kernel/dma/pool.c index 35bb51c31fff370f..1c7eab2cc0498003 100644 --- a/kernel/dma/po

Re: [PATCH v3 18/25] drm: rcar-du: fix common struct sg_table related issues

2020-05-05 Thread Geert Uytterhoeven
PATCH v3 00/25] DRM: fix struct sg_table nents > vs. orig_nents misuse' thread: https://lkml.org/lkml/2020/5/5/187 For the modern lore-users: https://lore.kernel.org/r/20200505083926.28503-1-m.szyprow...@samsung.com/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- The

Re: [PATCH v5] dt-bindings: iommu: renesas, ipmmu-vmsa: convert to json-schema

2020-04-21 Thread Geert Uytterhoeven
Gen2. So, renesas,ipmmu-r8a73a4 belongs the renesas,ipmmu-vmsa > section. > > Signed-off-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

Re: [PATCH 24/29] mm: remove __vmalloc_node_flags_caller

2020-04-20 Thread Geert Uytterhoeven
e: > FAILED linux-next/m5272c3_defconfig/m68k-gcc8 Mon Apr 20, 18:38 > > http://kisskb.ellerman.id.au/kisskb/buildresult/14213623/ > > mm/nommu.c:164:25: error: 'flags' undeclared (first use in this function); > did you mean 'class'? "return __vmalloc(size, gfp_mask);" Gr

Re: [PATCH 26/29] mm: remove vmalloc_user_node_flags

2020-04-20 Thread Geert Uytterhoeven
.id.au/kisskb/buildresult/14213623/ > > mm/nommu.c:158:25: error: 'flags' undeclared (first use in this function); > did you mean 'class'? "return __vmalloc(size, gfp_mask);", I assume? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux b

Re: [PATCH v4] dt-bindings: iommu: renesas, ipmmu-vmsa: convert to json-schema

2020-04-17 Thread Geert Uytterhoeven
t bits at all. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "

Re: [PATCH v4] dt-bindings: iommu: renesas, ipmmu-vmsa: convert to json-schema

2020-04-17 Thread Geert Uytterhoeven
Gen2. So, renesas,ipmmu-r8a73a4 belongs the renesas,ipmmu-vmsa > section. > > Signed-off-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

Re: [PATCH] dt-bndings: iommu: renesas, ipmmu-vmsa: convert to json-schema

2020-04-16 Thread Geert Uytterhoeven
Hi Shimoda-san, On Thu, Apr 16, 2020 at 11:56 AM Yoshihiro Shimoda wrote: > > From: Geert Uytterhoeven, Sent: Wednesday, April 15, 2020 11:21 PM > > On Tue, Apr 14, 2020 at 2:26 AM Yoshihiro Shimoda > > wrote: > > > Convert Renesas VMSA-Compatible IOMMU bindings

Re: [PATCH] dt-bndings: iommu: renesas, ipmmu-vmsa: convert to json-schema

2020-04-15 Thread Geert Uytterhoeven
the main IPMMU IMSSTR register. Only used by > + cache IPMMU instances. This property is not valid only on R-Car Gen2 and R-Mobile APE6. (untested) oneOf: - properties: contains: const: renesas,ipmmu-vmsa - properties: renesas,ipmmu-main: $ref: /schemas/types.

Re: [PATCH] netfilter: nft_fwd_netdev: Fix CONFIG_NET_CLS_ACT=n build

2020-04-10 Thread Geert Uytterhoeven
On Fri, Apr 10, 2020 at 4:26 PM Geert Uytterhoeven wrote: > If CONFIG_NET_CLS_ACT=n: > > net/netfilter/nft_fwd_netdev.c: In function ‘nft_fwd_netdev_eval’: > net/netfilter/nft_fwd_netdev.c:32:10: error: ‘struct sk_buff’ has no > member named ‘tc_redirected’ &

[PATCH] iommu: Fix MTK_IOMMU dependencies

2020-04-10 Thread Geert Uytterhoeven
at it, remove the dependency on ARM || ARM64, as that is already implied by the dependency on ARCH_MEDIATEK. Fixes: e93a1695d7fb5513 ("iommu: Enable compile testing for some of drivers") Signed-off-by: Geert Uytterhoeven --- drivers/iommu/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH] netfilter: nft_fwd_netdev: Fix CONFIG_NET_CLS_ACT=n build

2020-04-10 Thread Geert Uytterhoeven
irect to ifb via ingress") Signed-off-by: Geert Uytterhoeven --- net/netfilter/nft_fwd_netdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/netfilter/nft_fwd_netdev.c b/net/netfilter/nft_fwd_netdev.c index 74f050ba6badc9dc..ebcaf5c325712f30 100644 --- a/net/netfilter/nft_

Re: How to fix WARN from drivers/base/dd.c in next-20200401 if CONFIG_MODULES=y?

2020-04-03 Thread Geert Uytterhoeven
Hi John, On Fri, Apr 3, 2020 at 1:47 PM Geert Uytterhoeven wrote: > On Thu, Apr 2, 2020 at 7:27 PM John Stultz wrote: > > On Thu, Apr 2, 2020 at 3:17 AM Yoshihiro Shimoda > > wrote: > > > > > > I found an issue after applied the following patches: > >

Re: How to fix WARN from drivers/base/dd.c in next-20200401 if CONFIG_MODULES=y?

2020-04-03 Thread Geert Uytterhoeven
-Sending DHCP requests .., OK -IP-Config: Got DHCP answer from ... ... +VFS: Unable to mount root fs via NFS, trying floppy. +VFS: Cannot open root device "nfs" or unknown-block(2,0): error -6 > Does booting with deferred_probe_timeout=0 work? It does, as now everyth

Re: [PATCH] dma-debug: dynamic allocation of hash table

2020-01-31 Thread Geert Uytterhoeven
ion). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.

Re: [PATCH -next] iommu/ipmmu-vmsa: Remove dev_err() on platform_get_irq() failure

2019-10-23 Thread Geert Uytterhoeven
On Wed, Oct 23, 2019 at 4:01 PM YueHaibing wrote: > platform_get_irq() will call dev_err() itself on failure, > so there is no need for the driver to also do this. > This is detected by coccinelle. > > Signed-off-by: YueHaibing Reviewed-by: Geert Uytterhoeven Gr

Re: [PATCH v2 5/6] iommu/ipmmu-vmsa: Add helper functions for "uTLB" registers

2019-10-16 Thread Geert Uytterhoeven
off-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalis

Re: [PATCH v2 4/6] iommu/ipmmu-vmsa: Calculate context registers' offset instead of a macro

2019-10-16 Thread Geert Uytterhoeven
moda Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just

Re: [PATCH v2 3/6] iommu/ipmmu-vmsa: Add helper functions for MMU "context" registers

2019-10-16 Thread Geert Uytterhoeven
hihiro Shimoda Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalis

Re: [PATCH 3/3] iommu/ipmmu-vmsa: Add utlb_offset_base

2019-10-11 Thread Geert Uytterhoeven
le: ipmmu_imuasid_write(mmu, utlb, 0); ipmmu_imuctr_write(mmu, utlb, data); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

Re: [PATCH 2/3] iommu/ipmmu-vmsa: Calculate context registers' offset instead of a macro

2019-10-11 Thread Geert Uytterhoeven
pers ipmmu_ctx_{read,write}(), so all users can just use e.g. ipmmu_ctx_write(mmu, context_id, reg, data); instead of ipmmu_write(mmu, ipmmu_ctx_reg(mmu, context_id, reg), data); ? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

Re: [PATCH 1/3] iommu/ipmmu-vmsa: Remove some unused register declarations

2019-10-11 Thread Geert Uytterhoeven
(1 << 17) > #define IMCTR_AFE (1 << 16) > -#define IMCTR_RTSEL_MASK (3 << 4) FWIW, this is valid for R-Car Gen2 only. On R-Car Gen3, the field contains 3 bits. Gr{oetje,eeting}s, Geert -- Geert Uytterh

Re: [RESEND TRIVIAL 3/3] treewide: arch: Fix Kconfig indentation

2019-10-07 Thread Geert Uytterhoeven
| 2 +- > arch/m68k/Kconfig.debug| 16 > arch/m68k/Kconfig.machine | 8 ---- For m68k: Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32

Re: [PATCH] dma-mapping: fix false positivse warnings in dma_common_free_remap()

2019-10-07 Thread Geert Uytterhoeven
rom [<8013ad14>] > (kernel_restart+0x1c/0x60) > [<8013acf8>] (kernel_restart) from [<8013af84>] (__do_sys_reboot+0xe0/0x1d8) > r5:81c03048 r4: > [<8013aea4>] (__do_sys_reboot) from [<8013b0ec>] (sys_reboot+0x18/0x1c) > r8:80101204 r7:0058 r

  1   2   3   4   >