Re: [PATCH v6] iommu/arm-smmu-qcom: Request direct mapping for modem device

2020-05-15 Thread Sibi Sankar
Hey Will, On 2020-05-11 23:25, Sibi Sankar wrote: The modem remote processor has two access paths to DDR. One path is directly connected to DDR and another path goes through an SMMU. The SMMU path is configured to be a direct mapping because it's used by various peripherals in the modem

[PATCH v6] iommu/arm-smmu-qcom: Request direct mapping for modem device

2020-05-11 Thread Sibi Sankar
the kernel program the SIDs for the modem in these cases. Signed-off-by: Sibi Sankar --- V6 * Rebased on Will's for-joerg/arm-smmu/updates * Reword commit message and add more details [Stephen] drivers/iommu/arm-smmu-qcom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iommu/arm

Re: [PATCH v5] iommu/arm-smmu-qcom: Request direct mapping for modem device

2020-05-08 Thread Sibi Sankar
Hey Stephen, Thanks for taking time to review the patch. On 5/8/20 2:44 AM, Stephen Boyd wrote: Quoting Sibi Sankar (2020-05-07 12:21:57) The modem remote processor has two modes of access to the DDR, a direct mode and through a SMMU which requires direct mapping. The configuration

[PATCH v5] iommu/arm-smmu-qcom: Request direct mapping for modem device

2020-05-07 Thread Sibi Sankar
to opt in for direct mapping on such platforms. Signed-off-by: Sai Prakash Ranjan Signed-off-by: Sibi Sankar --- V5 * Reword commit message and drop unnecessary details drivers/iommu/arm-smmu-qcom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iommu/arm-smmu-qcom.c b/drivers

Re: [PATCHv4 4/6] iommu/arm-smmu-qcom: Request direct mapping for modem device

2020-05-07 Thread Sibi Sankar
Hey WIll, On 2020-05-07 18:32, Will Deacon wrote: On Tue, Apr 21, 2020 at 12:03:52AM +0530, Sai Prakash Ranjan wrote: From: Sibi Sankar The Q6 modem sub-system has direct access to DDR through memnoc. Also SMMU is not expected to provide access control/translation for these SIDs (sandboxing

Re: [PATCH v2 0/3] Request direct mapping for modem device

2020-03-17 Thread Sibi Sankar
On 2020-03-17 20:39, Sibi Sankar wrote: The Q6 modem sub-system has direct access to DDR through memnoc and an indirect access routed through a SMMU which MSS CE (crypto engine sub-component of MSS) uses during out of reset sequence. Request direct mapping for the modem device since smmu

[PATCH v2 1/3] dt-bindings: remoteproc: qcom: Add iommus property

2020-03-17 Thread Sibi Sankar
Add iommus property to allow Q6 modem to boot on platforms which do not have trustZone. Signed-off-by: Sibi Sankar --- Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt b

[PATCH v2 3/3] arm64: dts: qcom: sdm845-cheza: Add iommus property

2020-03-17 Thread Sibi Sankar
Add iommus property to remoteproc modem node. Signed-off-by: Sibi Sankar --- arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi index 8d16d016efec1

[PATCH v2 2/3] remoteproc: qcom_q6v5_mss: Request direct mapping for modem device

2020-03-17 Thread Sibi Sankar
0x, GFSYNR1 0x0781, GFSYNR2 0x arm-smmu 1500.iommu: Unexpected global fault, this could be serious arm-smmu 1500.iommu: GFSR 0x8002, GFSYNR0 0x, GFSYNR1 0x0461, GFSYNR2 0x Signed-off-by: Sibi Sankar

[PATCH v2 0/3] Request direct mapping for modem device

2020-03-17 Thread Sibi Sankar
, GFSYNR1 0x0461, GFSYNR2 0x V2: * Request direct mapping from SoC-specific corner of the SMMU driver [Robin] * Add iommu property to remoteproc modem node on Cheza Depends on: https://lore.kernel.org/patchwork/cover/1183528/ Sibi Sankar (3): dt-bindings

Re: [PATCH 0/3] Request direct mapping for modem firmware subdevice

2020-03-16 Thread Sibi Sankar
Hey Christoph, Thanks for taking time to review the series. On 2020-03-16 21:20, Christoph Hellwig wrote: On Mon, Mar 09, 2020 at 11:52:52PM +0530, Sibi Sankar wrote: The Q6 modem sub-system has direct access to DDR through memnoc and an indirect access routed through a SMMU which MSS CE

Re: [PATCH 0/3] Request direct mapping for modem firmware subdevice

2020-03-10 Thread Sibi Sankar
Hey Joerg, Thanks for taking time to review the series! On 2020-03-10 16:53, Joerg Roedel wrote: On Mon, Mar 09, 2020 at 11:52:52PM +0530, Sibi Sankar wrote: The Q6 modem sub-system has direct access to DDR through memnoc and an indirect access routed through a SMMU which MSS CE (crypto engine

[PATCH 2/3] dt-bindings: remoteproc: qcom: Add modem-firmware bindings

2020-03-09 Thread Sibi Sankar
Introduce modem-firmware binding to allow Q6 modem to boot on platforms which do not have trustZone. Signed-off-by: Sibi Sankar --- Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/remoteproc

[PATCH 3/3] remoteproc: qcom_q6v5_mss: Request direct mapping for firmware subdevice

2020-03-09 Thread Sibi Sankar
control/translation for these SIDs (sandboxing of the modem is achieved through XPUs engaged using SMC calls). Signed-off-by: Sibi Sankar --- drivers/remoteproc/qcom_q6v5_mss.c | 68 ++ 1 file changed, 68 insertions(+) diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b

[PATCH 1/3] iommu: Export "iommu_request_dm_for_dev"

2020-03-09 Thread Sibi Sankar
Export "iommu_request_dm_for_dev" to allow for modular builds of drivers requesting for direct mapping. Signed-off-by: Sibi Sankar --- drivers/iommu/iommu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index 3e3528436e0b2..06a

[PATCH 0/3] Request direct mapping for modem firmware subdevice

2020-03-09 Thread Sibi Sankar
control/translation for these SIDs (sandboxing of the modem is achieved through XPUs engaged using SMC calls). Sibi Sankar (3): iommu: Export "iommu_request_dm_for_dev" dt-bindings: remoteproc: qcom: Add modem-firmware bindings remoteproc: qcom_q6v5_mss: Request direct mapping fo