Re: [PATCH] dt-bindings: Improve phandle-array schemas

1st arg cell > - description: 2nd arg cell > > With this change, some examples need updating so that the bracketing of > property values matches the schema. [..] > Signed-off-by: Rob Herring > --- Acked-by: Stephen Boyd ___

Re: [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver

Quoting Yong Wu (2022-01-14 23:39:52) > On Fri, 2022-01-14 at 15:30 -0600, Stephen Boyd wrote: > > > > This sounds more correct to me. I'm not an expert on runtime PM > > though > > as I always have to read the code to remember how it works. if the > > device

Re: [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver

Quoting Yong Wu (2022-01-14 01:06:31) > On Wed, 2022-01-12 at 20:25 -0800, Stephen Boyd wrote: > > > > > > [2.654526] [ cut here ] > > > [2.68] refcount_t: addition on 0; use-after-free. > > > > > > After this pa

Re: [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver

Quoting Yong Wu (2022-01-12 01:09:19) > On Tue, 2022-01-11 at 16:27 -0800, Stephen Boyd wrote: > > ---8<--- > > diff --git a/drivers/base/component.c b/drivers/base/component.c > > index 64ad7478c67a..97f253a41bdf 100644 > > --- a/drivers/base/component.c >

Re: [PATCH] dt-bindings: More dropping redundant minItems/maxItems

re equal to the 'items' length. > An improved meta-schema is pending. > > Cc: Stephen Boyd > Cc: Joerg Roedel > Cc: Will Deacon > Cc: Krzysztof Kozlowski > Cc: Miquel Raynal > Cc: Richard Weinberger > Cc: Vignesh Raghavendra > Cc: Alessandro Zummo > Cc: Alexa

Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples

Quoting Rob Herring (2021-02-02 12:55:42) > Running 'dt-validate -m' will flag any compatible strings missing a schema. > Fix all the errors found in DT binding examples. Most of these are just > typos. > > Cc: Stephen Boyd > Cc: Maxime Ripard > Cc: Chen-Yu Tsai >

Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples

Quoting Rob Herring (2021-02-02 12:55:42) > > diff --git > a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml > b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml > index fa0ee03a527f..53cc6df0df96 100644 > --- >

Re: [PATCH v2 3/5] irqchip: Allow QCOM_PDC to be loadable as a permanent module

Quoting John Stultz (2020-07-10 15:44:18) > On Thu, Jul 9, 2020 at 11:02 PM Stephen Boyd wrote: > > > > Does it work? I haven't looked in detail but I worry that the child > > irqdomain (i.e. pinctrl-msm) would need to delay probing until this > > parent irqd

Re: [PATCH v2 3/5] irqchip: Allow QCOM_PDC to be loadable as a permanent module

Quoting Marc Zyngier (2020-06-27 02:37:47) > On Sat, 27 Jun 2020 02:34:25 +0100, > John Stultz wrote: > > > > On Fri, Jun 26, 2020 at 12:42 AM Stephen Boyd wrote: > > > > > > > > > Is there any reason to use IRQCHIP_DECLARE if this can work as a >

Re: [PATCH v2 3/5] irqchip: Allow QCOM_PDC to be loadable as a permanent module

Quoting John Stultz (2020-06-24 17:10:37) > diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c > index 6ae9e1f0819d..3fee8b655da1 100644 > --- a/drivers/irqchip/qcom-pdc.c > +++ b/drivers/irqchip/qcom-pdc.c > @@ -430,4 +432,33 @@ static int qcom_pdc_init(struct device_node *node,

Re: [PATCH v6] iommu/arm-smmu-qcom: Request direct mapping for modem device

programming the modem SIDs to the > kernel. Let's add compatibles here so that we can have the kernel > program the SIDs for the modem in these cases. > > Signed-off-by: Sibi Sankar > --- Reviewed-by: Stephen Boyd ___ iommu mailing l

Re: [PATCH v5] iommu/arm-smmu-qcom: Request direct mapping for modem device

Quoting Sibi Sankar (2020-05-07 12:21:57) > The modem remote processor has two modes of access to the DDR, a direct > mode and through a SMMU which requires direct mapping. The configuration > of the modem SIDs is handled in TrustZone. Is it "The configuration of the modem SIDs is typically

Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers

Quoting Hadar Gat (2020-04-16 02:49:03) > Both of_platform.h and of_device.h were included each other. > In of_device.h, removed unneeded #include to of_platform.h > and added include to of_platform.h in the files that needs it. > > Signed-off-by: Hadar Gat > --- Acked-by: S

Re: [RFC PATCH 08/11] clk: Remove Calxeda driver

Quoting Rob Herring (2020-02-18 09:13:18) > Cc: Stephen Boyd > Cc: linux-...@vger.kernel.org > Signed-off-by: Rob Herring > --- Acked-by: Stephen Boyd ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation

Re: [PATCH 1/2] iommu: arm-smmu-impl: Convert to a generic reset implementation

o add SC7180 SMMU > compatible for calling into QCOM specific implementation. > > Signed-off-by: Sai Prakash Ranjan > --- Reviewed-by: Stephen Boyd ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH] iommu/ipmmu-vmsa: Only call platform_get_irq() when interrupt is mandatory

orm_get_irq() down, where the > existence of the interrupt is mandatory. > > Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to > platform_get_irq*()") > Signed-off-by: Geert Uytterhoeven > --- Reviewed-by: Stephen Boyd

Re: [PATCHv7 3/3] iommu: arm-smmu-impl: Add sdm845 implementation hook

if=/dev/sda of=/dev/zero bs=1048576 count=300 conv=sync > 300+0 records in > 300+0 records out > 314572800 bytes (300.0MB) copied, 1.030541 seconds, 291.1MB/s > real 0m 1.03s > user0m 0.00s > sys 0m 0.54s > > Signed-off-by: Vivek Gautam > Reviewed-by: Robin Murphy > Signed-off-by: Sai Prakash Ranjan > --- Reviewed-by: Stephen Boyd

Re: [PATCHv6 3/3] iommu: arm-smmu-impl: Add sdm845 implementation hook

Quoting Sai Prakash Ranjan (2019-09-19 11:54:27) > On 2019-09-19 08:48, Sai Prakash Ranjan wrote: > > On 2019-09-19 05:55, Bjorn Andersson wrote: > >> In the transition to this new design we lost the ability to > >> enable/disable the safe toggle per board, which according to Vivek > >> would

Re: [PATCHv6 3/3] iommu: arm-smmu-impl: Add sdm845 implementation hook

Quoting Sai Prakash Ranjan (2019-09-17 02:45:04) > diff --git a/drivers/iommu/arm-smmu-impl.c b/drivers/iommu/arm-smmu-impl.c > index 3f88cd078dd5..d62da270f430 100644 > --- a/drivers/iommu/arm-smmu-impl.c > +++ b/drivers/iommu/arm-smmu-impl.c > @@ -9,7 +9,6 @@ > > #include "arm-smmu.h" > > -

Re: [PATCHv6 2/3] firmware/qcom_scm: Add scm call to handle smmu errata

rough a > SCM call. > > Signed-off-by: Vivek Gautam > Reviewed-by: Bjorn Andersson > Signed-off-by: Sai Prakash Ranjan > --- Reviewed-by: Stephen Boyd ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCHv6 3/3] iommu: arm-smmu-impl: Add sdm845 implementation hook

Quoting Bjorn Andersson (2019-09-18 17:25:01) > On Tue 17 Sep 02:45 PDT 2019, Sai Prakash Ranjan wrote: > > > From: Vivek Gautam > > > > There are other boards such as cheza whose bootloaders don't enable this > > logic. Such boards don't implement callbacks to handle the specific SCM > > call

Re: [PATCHv6 1/3] firmware: qcom_scm-64: Add atomic version of qcom_scm_call

rnel/msm-4.9/ > tree/drivers/iommu/arm-smmu.c?h=msm-4.9#n4842") > > Signed-off-by: Vivek Gautam > Reviewed-by: Bjorn Andersson > Signed-off-by: Sai Prakash Ranjan > --- Reviewed-by: Stephen Boyd

Re: [PATCH 2/7] dt-bindings: arm-smmu: Add Adreno GPU variant

Quoting Jordan Crouse (2019-08-20 12:06:27) > Add a compatible string to identify SMMUs that are attached > to Adreno GPU devices that wish to support split pagetables. > > Signed-off-by: Jordan Crouse > --- > > Documentation/devicetree/bindings/iommu/arm,smmu.txt | 7 +++ > 1 file

Re: [PATCH 3/7] iommu/arm-smmu: Add a SMMU variant for the Adreno GPU

Quoting Jordan Crouse (2019-08-20 12:06:28) > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index 39e81ef..3f41cf7 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -1858,6 +1858,7 @@ ARM_SMMU_MATCH_DATA(arm_mmu401, ARM_SMMU_V1_64K, >

Re: [PATCH v4 1/3] firmware: qcom_scm-64: Add atomic version of qcom_scm_call

Quoting Vivek Gautam (2019-08-22 23:32:46) > There are scnenarios where drivers are required to make a > scm call in atomic context, such as in one of the qcom's > arm-smmu-500 errata [1]. > > [1] ("https://source.codeaurora.org/quic/la/kernel/msm-4.9/ >

Re: [PATCH v4 3/3] iommu: arm-smmu-impl: Add sdm845 implementation hook

Quoting Vivek Gautam (2019-08-22 23:32:48) > diff --git a/drivers/iommu/arm-smmu-impl.c b/drivers/iommu/arm-smmu-impl.c > index 3f88cd078dd5..0aef87c41f9c 100644 > --- a/drivers/iommu/arm-smmu-impl.c > +++ b/drivers/iommu/arm-smmu-impl.c > @@ -102,7 +103,6 @@ static struct arm_smmu_device >

[PATCH v6 22/57] iommu: Remove dev_err() usage after platform_get_irq()

.linux-foundation.org Cc: Greg Kroah-Hartman Signed-off-by: Stephen Boyd --- Please apply directly to subsystem trees drivers/iommu/exynos-iommu.c | 4 +--- drivers/iommu/msm_iommu.c| 1 - drivers/iommu/qcom_iommu.c | 4 +--- 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers

Re: [PATCH v18 1/5] iommu/arm-smmu: Add pm_runtime/sleep ops

Quoting Vivek Gautam (2018-12-02 22:43:38) > On Fri, Nov 30, 2018 at 11:45 PM Will Deacon wrote: > > > > On Thu, Nov 29, 2018 at 08:25:20PM +0530, Vivek Gautam wrote: > > > clk_bulk_get_all() seems like going only the OF way. > > > Is there another way here to have something common between ACPI >

[PATCH v3] dma-debug: Check for drivers mapping invalid addresses in dma_map_single()

is happens. This makes it a little easier to debug these sorts of problems, instead of seeing odd behavior or crashes when drivers attempt to map the vmalloc space for DMA. Cc: Marek Szyprowski Reviewed-by: Robin Murphy Signed-off-by: Stephen Boyd --- Changes from v2: * Rename function properly an

Re: [PATCH v2] dma-debug: Check for drivers mapping invalid addresses in dma_map_single()

Quoting Robin Murphy (2018-10-02 07:01:42) > On 01/10/18 22:53, Stephen Boyd wrote: > > diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h > > index d23fc45c8208..99ccba66c06a 100644 > > --- a/include/linux/dma-mapping.h > > +++ b/include/linux/

[PATCH v2] dma-debug: Check for drivers mapping invalid addresses in dma_map_single()

is happens. This makes it a little easier to debug these sorts of problems, instead of seeing odd behavior or crashes when drivers attempt to map the vmalloc space for DMA. Cc: Marek Szyprowski Cc: Robin Murphy Signed-off-by: Stephen Boyd --- Changes from v1: * Update code to check for inval

Re: [PATCH] dma-debug: Check for drivers mapping vmalloc addresses

Quoting Robin Murphy (2018-09-26 06:24:42) > On 21/09/18 18:39, Stephen Boyd wrote: > > Quoting Robin Murphy (2018-09-21 04:09:50) > >> Hi Stephen, > >> > >> On 20/09/18 23:35, Stephen Boyd wrote: > >>> I recently debugged a DMA mapping oops where a

Re: [PATCH] dma-debug: Check for drivers mapping vmalloc addresses

Quoting Christoph Hellwig (2018-09-20 22:25:37) > On Thu, Sep 20, 2018 at 03:35:59PM -0700, Stephen Boyd wrote: > > I recently debugged a DMA mapping oops where a driver was trying to map > > a buffer returned from request_firmware() with dma_map_single(). Memory > > returned

Re: [PATCH] dma-debug: Check for drivers mapping vmalloc addresses

Quoting Robin Murphy (2018-09-21 04:09:50) > Hi Stephen, > > On 20/09/18 23:35, Stephen Boyd wrote: > > I recently debugged a DMA mapping oops where a driver was trying to map > > a buffer returned from request_firmware() with dma_map_single(). Memory > > ret

Re: [PATCH V4 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

ark <robdcl...@gmail.com> wrote: > >>> On Thu, Jul 13, 2017 at 1:35 AM, Sricharan R <sricha...@codeaurora.org> > >>> wrote: > >>>> Hi Vivek, > >>>> > >>>> On 7/13/2017 10:43 AM, Vivek Gautam wrote: > >>>>&

Re: [PATCH V4 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

On 07/13, Vivek Gautam wrote: > Hi Stephen, > > > On 07/13/2017 04:24 AM, Stephen Boyd wrote: > >On 07/06, Vivek Gautam wrote: > >>@@ -1231,12 +1237,18 @@ static int arm_smmu_map(struct iommu_domain > >>*domain, unsigned long iova, > >> static size

Re: [PATCH V4 2/6] iommu/arm-smmu: Add pm_runtime/sleep ops

On 07/12, Stephen Boyd wrote: > On 07/06, Vivek Gautam wrote: > > From: Sricharan R <sricha...@codeaurora.org> > > > > The smmu needs to be functional only when the respective > > master's using it are active. The device_link feature > > helps to

Re: [PATCH V4 2/6] iommu/arm-smmu: Add pm_runtime/sleep ops

On 07/06, Vivek Gautam wrote: > From: Sricharan R > > The smmu needs to be functional only when the respective > master's using it are active. The device_link feature > helps to track such functional dependencies, so that the > iommu gets powered when the master device

Re: [PATCH V4 4/6] iommu/arm-smmu: Add the device_link between masters and smmu

On 07/06, Vivek Gautam wrote: > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index ddbfa8ab69e6..75567d9698ab 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -1348,6 +1348,7 @@ static int arm_smmu_add_device(struct device *dev) > struct

Re: [PATCH V4 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

On 07/06, Vivek Gautam wrote: > @@ -1231,12 +1237,18 @@ static int arm_smmu_map(struct iommu_domain *domain, > unsigned long iova, > static size_t arm_smmu_unmap(struct iommu_domain *domain, unsigned long iova, >size_t size) > { > - struct io_pgtable_ops *ops =

Re: [PATCH V3 0/5] iommu/arm-smmu: Add runtime pm/sleep support

On 04/03, Will Deacon wrote: > On Fri, Mar 31, 2017 at 10:58:16PM -0400, Rob Clark wrote: > > On Fri, Mar 31, 2017 at 1:54 PM, Will Deacon wrote: > > > On Thu, Mar 09, 2017 at 09:05:43PM +0530, Sricharan R wrote: > > >> This series provides the support for turning on the

Re: [PATCH 5/9] iommu: add qcom_iommu

On 03/01/2017 09:42 AM, Rob Clark wrote: > diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c > new file mode 100644 > index 000..5d3bb63 > --- /dev/null > +++ b/drivers/iommu/qcom_iommu.c > @@ -0,0 +1,825 @@ > +/* > + * IOMMU API for QCOM secure IOMMUs. Somewhat based on

Re: [PATCH 6/9] iommu: qcom: initialize secure page table

On 03/01/2017 09:42 AM, Rob Clark wrote: > From: Stanimir Varbanov > > This bassicaly get the secure page table size, allocate memory s/bassicaly/basically/ s/get/gets/ s/allocate/allocates/ Heh, bass. > and return back the physical address to the trusted zone.

[PATCH 0/5] Remove qcom SoC configs

driver is already taken in the qcom_defconfig, so most likely nobody will care. Cc: Joerg Roedel <j...@8bytes.org> Stephen Boyd (5): iommu: Generalize MSM_IOMMU config to ARCH_QCOM ARM: Makefile: Generalize qcom platform text offset ARM: qcom: Remove SoC specific configs ARM: qcom_def

[PATCH 1/5] iommu: Generalize MSM_IOMMU config to ARCH_QCOM

We want to get rid of the ARCH_MSM* configs in the future, but this still depends on them. Generalize to the ARCH_QCOM config, which isn't going away. Cc: Joerg Roedel <j...@8bytes.org> Signed-off-by: Stephen Boyd <sb...@codeaurora.org> --- drivers/iommu/Kconfig | 2 +- 1 fil

Re: [PATCH] iommu: mtk: add common-clk dependency

On 11/17, Honghui Zhang wrote: > On Wed, 2016-11-16 at 11:38 -0800, Stephen Boyd wrote: > > On 11/16, Arnd Bergmann wrote: > > > After the MT2701 clock driver was added, we get a harmless warning for > > > the iommu driver that selects it, when compile-testi

Re: [PATCH] iommu: mtk: add common-clk dependency

On 11/16, Arnd Bergmann wrote: > After the MT2701 clock driver was added, we get a harmless warning for > the iommu driver that selects it, when compile-testing without > COMMON_CLK. > > warning: (MTK_IOMMU_V1) selects COMMON_CLK_MT2701_IMGSYS which has unmet > direct dependencies (COMMON_CLK) >

Re: [v7, 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl

On 03/31/2016 08:07 PM, Yangbo Lu wrote: > drivers/clk/clk-qoriq.c | 3 +-- > For clk part: Acked-by: Stephen Boyd <sb...@codeaurora.org> -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collabora

Re: [PATCH 3/5] iommu/msm: Add support for generic master bindings

On 08/12/2015 07:47 AM, Sricharan R wrote: @@ -702,6 +703,44 @@ static void print_ctx_regs(void __iomem *base, int ctx) GET_PRRR(base, ctx), GET_NMRR(base, ctx)); } +static void insert_iommu_master(struct device *dev, + struct msm_iommu_dev

Re: [PATCH 02/18] firmware: qcom_scm-32: replace open-coded call to __cpuc_flush_dcache_area()

On 07/27/2015 05:28 AM, Russell King wrote: Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- Thanks! Reviewed-by: Stephen Boyd sb...@codeaurora.org arch/arm/include/asm/cacheflush.h | 17 + drivers/firmware/qcom_scm-32.c| 4 +--- 2 files changed, 18

Re: [RFC PATCH 4/4] iommu/arm-smmu: Add support for specifying regulators

On 07/17/2015 09:53 AM, Sricharan R wrote: From: Mitchel Humpherys mitch...@codeaurora.org This adds the support to turn on the regulators required for SMMUs. It is turned on during the SMMU probe and remains 'on' till the device exists. The device always exists. Until the driver is removed

Re: [RFC] iommu: qcom-iommu-v0 IOMMU

On 07/10, Rob Clark wrote: So, in it's current form, this is superficially a copy of msm_iommu plus DT conversion. But the pre-DT IOMMU driver had fairly different structure.. ie. psuedo root device, with IOMMU devices hanging off that, and context devices hanging off that. The context