Re: [PATCH] x86/iommu: Fix two minimal issues in check_iommu_entries()

On Tue, Jan 5, 2021 at 3:04 AM Konrad Rzeszutek Wilk wrote: > > On Wed, Dec 23, 2020 at 02:24:12PM +0800, Zhenzhong Duan wrote: > > check_iommu_entries() checks for cyclic dependency in iommu entries > > and fixes the cyclic dependency by setting x->depend to NULL. But >

Re: [PATCH] x86/iommu: Fix two minimal issues in check_iommu_entries()

On Wed, Dec 30, 2020 at 3:02 PM Borislav Petkov wrote: > > On Wed, Dec 23, 2020 at 02:24:12PM +0800, Zhenzhong Duan wrote: > > check_iommu_entries() checks for cyclic dependency in iommu entries > > and fixes the cyclic dependency by setting x->depend to NULL. But > > t

[PATCH] x86/iommu: Fix two minimal issues in check_iommu_entries()

. The second issue is about the report of exectuion order reverse, the order is reversed incorrectly in the report, fix it. Signed-off-by: Zhenzhong Duan --- arch/x86/kernel/pci-iommu_table.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/pci-iommu_ta

Re: [PATCH v2] iommu/vt-d: avoid unnecessory panic if iommu init fail in tboot system

Hi Lukasz, On Tue, Nov 10, 2020 at 11:53 PM Lukasz Hawrylko wrote: > > Hi Zhenzhong > > On Tue, 2020-11-10 at 15:19 +0800, Zhenzhong Duan wrote: > > "intel_iommu=off" command line is used to disable iommu but iommu is force > > enabled in a tboot system fo

[PATCH v2] iommu/vt-d: avoid unnecessory panic if iommu init fail in tboot system

e Intel IOMMU force on") Signed-off-by: Zhenzhong Duan --- v2: move ckeck of intel_iommu_tboot_noforce into iommu code per Baolu. arch/x86/kernel/tboot.c | 3 --- drivers/iommu/intel/iommu.c | 5 +++-- include/linux/intel-iommu.h | 1 - 3 files changed, 3 insertions(+), 6 deletions(-)

Re: [PATCH] iommu/vt-d: avoid unnecessory panic if iommu init fail in tboot

Hi Baolu, On Mon, Nov 9, 2020 at 11:15 AM Lu Baolu wrote: > > Hi Zhenzhong, > > On 11/9/20 10:27 AM, Zhenzhong Duan wrote: > > +intel iommu maintainers, > > > > Can anyone help review this patch? Thanks > > > > Zhenzhong > > > > On

Re: [PATCH] iommu/vt-d: avoid unnecessory panic if iommu init fail in tboot

+intel iommu maintainers, Can anyone help review this patch? Thanks Zhenzhong On Wed, Nov 4, 2020 at 4:15 PM Zhenzhong Duan wrote: > > "intel_iommu=off" command line is used to disable iommu and iommu is force > enabled in a tboot system. Meanwhile "intel_iommu=tb

Re: [PATCH] iommu/vt-d: remove redundant variable no_platform_optin

Hi Baolu, On Thu, Nov 5, 2020 at 9:47 AM Lu Baolu wrote: > > Hi Zhenzhong, > > On 11/4/20 4:19 PM, Zhenzhong Duan wrote: > > no_platform_optin is redundant with dmar_disabled and it's only used in > > platform_optin_force_iommu(), remove it and use dmar_disabled in

[PATCH] iommu/vt-d: remove redundant variable no_platform_optin

no_platform_optin is redundant with dmar_disabled and it's only used in platform_optin_force_iommu(), remove it and use dmar_disabled instead. Meanwhile remove all the dead code in platform_optin_force_iommu(). Signed-off-by: Zhenzhong Duan --- drivers/iommu/intel/iommu.c | 14

[PATCH] iommu/vt-d: fix the wrong printing in RHSA parsing

When base address in RHSA structure doesn't match base address in each DRHD structure, the base address in last DRHD is printed out. This doesn't make sense when there are multiple DRHD units, fix it by printing the buggy RHSA's base address. Signed-off-by: Zhenzhong Duan Cc: David Woodhouse