Re: [PATCH 15/15] dma-mapping: bypass indirect calls for dma-direct

2018-12-20 Thread Christoph Hellwig
On Thu, Dec 20, 2018 at 05:44:18PM +0100, Thierry Reding wrote: > On Fri, Dec 07, 2018 at 11:07:20AM -0800, Christoph Hellwig wrote: > [...] > > diff --git a/kernel/dma/mapping.c b/kernel/dma/mapping.c > > index 0b18cfbdde95..fc84c81029d9 100644 > > --- a/kernel/dma/mapping.c > > +++

Re: [PATCH 15/15] dma-mapping: bypass indirect calls for dma-direct

2018-12-20 Thread Thierry Reding
On Fri, Dec 07, 2018 at 11:07:20AM -0800, Christoph Hellwig wrote: [...] > diff --git a/kernel/dma/mapping.c b/kernel/dma/mapping.c > index 0b18cfbdde95..fc84c81029d9 100644 > --- a/kernel/dma/mapping.c > +++ b/kernel/dma/mapping.c [...] > @@ -397,9 +404,9 @@ int dma_supported(struct device *dev,

Re: [15/15] dma-mapping: bypass indirect calls for dma-direct

2018-12-18 Thread Christoph Hellwig
On Tue, Dec 18, 2018 at 08:42:46PM +, Robin Murphy wrote: >> [ 16.046084] rk_iommu ff8f3f00.iommu: DMA map error for DT > > Yup, with this patch as-is, anything which isn't behind an IOMMU will be > erroneously banned from DMA entirely - see here: > >

Re: [15/15] dma-mapping: bypass indirect calls for dma-direct

2018-12-18 Thread Guillaume Tucker
On 07/12/2018 19:07, Christoph Hellwig wrote: > Avoid expensive indirect calls in the fast path DMA mapping > operations by directly calling the dma_direct_* ops if we are using > the directly mapped DMA operations. > > Signed-off-by: Christoph Hellwig > Signed-off-by: Christoph Hellwig >

Re: [15/15] dma-mapping: bypass indirect calls for dma-direct

2018-12-18 Thread Robin Murphy
On 2018-12-18 8:34 pm, Guillaume Tucker wrote: On 07/12/2018 19:07, Christoph Hellwig wrote: Avoid expensive indirect calls in the fast path DMA mapping operations by directly calling the dma_direct_* ops if we are using the directly mapped DMA operations. Signed-off-by: Christoph Hellwig

Re: [15/15] dma-mapping: bypass indirect calls for dma-direct

2018-12-16 Thread Christoph Hellwig
On Sat, Dec 15, 2018 at 09:46:54AM -0800, Guenter Roeck wrote: > Hi, > > On Fri, Dec 07, 2018 at 11:07:20AM -0800, Christoph Hellwig wrote: > > Avoid expensive indirect calls in the fast path DMA mapping > > operations by directly calling the dma_direct_* ops if we are using > > the directly

Re: [15/15] dma-mapping: bypass indirect calls for dma-direct

2018-12-15 Thread Guenter Roeck
Hi, On Fri, Dec 07, 2018 at 11:07:20AM -0800, Christoph Hellwig wrote: > Avoid expensive indirect calls in the fast path DMA mapping > operations by directly calling the dma_direct_* ops if we are using > the directly mapped DMA operations. > This patch results in arm64 boot failures. Reverting

Re: [PATCH 15/15] dma-mapping: bypass indirect calls for dma-direct

2018-12-14 Thread Marek Szyprowski
Hi Christoph, On 2018-12-14 15:24, Christoph Hellwig wrote: > On Fri, Dec 14, 2018 at 03:11:37PM +0100, Marek Szyprowski wrote: >> Hi Christoph, >> >> On 2018-12-07 20:07, Christoph Hellwig wrote: >>> Avoid expensive indirect calls in the fast path DMA mapping >>> operations by directly calling

Re: [PATCH 15/15] dma-mapping: bypass indirect calls for dma-direct

2018-12-14 Thread Christoph Hellwig
On Fri, Dec 14, 2018 at 03:11:37PM +0100, Marek Szyprowski wrote: > Hi Christoph, > > On 2018-12-07 20:07, Christoph Hellwig wrote: > > Avoid expensive indirect calls in the fast path DMA mapping > > operations by directly calling the dma_direct_* ops if we are using > > the directly mapped DMA

Re: [PATCH 15/15] dma-mapping: bypass indirect calls for dma-direct

2018-12-14 Thread Marek Szyprowski
Hi Christoph, On 2018-12-07 20:07, Christoph Hellwig wrote: > Avoid expensive indirect calls in the fast path DMA mapping > operations by directly calling the dma_direct_* ops if we are using > the directly mapped DMA operations. > > Signed-off-by: Christoph Hellwig This breaks direct DMA on

[PATCH 15/15] dma-mapping: bypass indirect calls for dma-direct

2018-12-07 Thread Christoph Hellwig
Avoid expensive indirect calls in the fast path DMA mapping operations by directly calling the dma_direct_* ops if we are using the directly mapped DMA operations. Signed-off-by: Christoph Hellwig --- arch/alpha/include/asm/dma-mapping.h | 2 +- arch/arc/mm/cache.c | 2 +-