Re: [GIT PULL] iommu/arm-smmu: fixes for 3.14

2014-02-20 Thread Joerg Roedel
Hi Will, On Thu, Feb 20, 2014 at 11:51:27AM +, Will Deacon wrote: > > Can the arm_smmu_devices_lock also be used in a DMA-API path? > > I don't think so -- that lock is only taken when: > > - Probing the SMMU > - Attaching a device to a domain (->attach_dev) > - Adding or removing a de

Re: [GIT PULL] iommu/arm-smmu: fixes for 3.14

2014-02-20 Thread Will Deacon
Hi Joerg, On Thu, Feb 20, 2014 at 11:29:19AM +, Joerg Roedel wrote: > On Tue, Feb 18, 2014 at 07:21:37PM +, Will Deacon wrote: > > FWIW, here's a diff you could apply as a fixup (or I can send a new pull > > request if you prefer). It's slightly messy because I had to rename a > > paramete

Re: [GIT PULL] iommu/arm-smmu: fixes for 3.14

2014-02-20 Thread Joerg Roedel
On Tue, Feb 18, 2014 at 07:21:37PM +, Will Deacon wrote: > FWIW, here's a diff you could apply as a fixup (or I can send a new pull > request if you prefer). It's slightly messy because I had to rename a > parameter in the page table functions (s/flag/prot/). > > What do you reckon? Hmm, am I

Re: [GIT PULL] iommu/arm-smmu: fixes for 3.14

2014-02-18 Thread Will Deacon
On Tue, Feb 18, 2014 at 06:36:26PM +, Will Deacon wrote: > On Tue, Feb 18, 2014 at 05:50:27PM +, Joerg Roedel wrote: > > I just did quick review of the changes. Was the SATA controller using > > the IOMMU through the DMA-API? In this case you would need the IRQ-safe > > spinlocks to avoid d

Re: [GIT PULL] iommu/arm-smmu: fixes for 3.14

2014-02-18 Thread Will Deacon
Hi Joerg, On Tue, Feb 18, 2014 at 05:50:27PM +, Joerg Roedel wrote: > On Mon, Feb 10, 2014 at 06:32:32PM +, Will Deacon wrote: > > - Andreas Herrmann took the driver for a run with a real SATA > > controller, which caused the new mutex-based locking to explode > > since we requir

Re: [GIT PULL] iommu/arm-smmu: fixes for 3.14

2014-02-18 Thread Joerg Roedel
On Mon, Feb 10, 2014 at 06:32:32PM +, Will Deacon wrote: > - Andreas Herrmann took the driver for a run with a real SATA > controller, which caused the new mutex-based locking to explode > since we require mappings in atomic context I just did quick review of the changes. Was the SAT

Re: [GIT PULL] iommu/arm-smmu: fixes for 3.14

2014-02-18 Thread Joerg Roedel
On Mon, Feb 10, 2014 at 06:32:32PM +, Will Deacon wrote: > The following changes since commit b28a960c42fcd9cfc987441fa6d1c1a471f0f9ed: > > Linux 3.14-rc2 (2014-02-09 18:15:47 -0800) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/will/linux.

[GIT PULL] iommu/arm-smmu: fixes for 3.14

2014-02-10 Thread Will Deacon
Hi Joerg, Please pull the following arm-smmu fixes for 3.14. The brief summary is: - Andreas Herrmann took the driver for a run with a real SATA controller, which caused the new mutex-based locking to explode since we require mappings in atomic context - Yifan fixed an issue with th