Re: [PATCH] MIPS: Fix `dma_alloc_coherent' returning a non-coherent allocation

2018-11-05 Thread Paul Burton
Hi Maciej, On Thu, Nov 01, 2018 at 07:54:24AM +, Maciej W. Rozycki wrote: > Fix a MIPS `dma_alloc_coherent' regression from commit bc3ec75de545 > ("dma-mapping: merge direct and noncoherent ops") that causes a cached > allocation to be returned on noncoherent cache systems. > > This is due

Re: [PATCH] MIPS: Fix `dma_alloc_coherent' returning a non-coherent allocation

2018-11-01 Thread Maciej W. Rozycki
On Thu, 1 Nov 2018, Christoph Hellwig wrote: > Oops, yes this looks good: BTW, for anyone missing hardware suitable for serious DMA testing I can recommend getting a pair of DEFPA cards, the ubiquitous PCI version of this board, cheaply available, which is the same except for a different host

Re: [PATCH] MIPS: Fix `dma_alloc_coherent' returning a non-coherent allocation

2018-11-01 Thread Christoph Hellwig
On Thu, Nov 01, 2018 at 07:54:24AM +, Maciej W. Rozycki wrote: > Fix a MIPS `dma_alloc_coherent' regression from commit bc3ec75de545 > ("dma-mapping: merge direct and noncoherent ops") that causes a cached > allocation to be returned on noncoherent cache systems. > > This is due to an invert

[PATCH] MIPS: Fix `dma_alloc_coherent' returning a non-coherent allocation

2018-11-01 Thread Maciej W. Rozycki
Fix a MIPS `dma_alloc_coherent' regression from commit bc3ec75de545 ("dma-mapping: merge direct and noncoherent ops") that causes a cached allocation to be returned on noncoherent cache systems. This is due to an inverted check now used in the MIPS implementation of `arch_dma_alloc' on the resu