Re: [PATCH] iomm/arm-smmu: Add stall implementation hook

2020-05-20 Thread Will Deacon
On Wed, May 20, 2020 at 03:02:45PM +0530, Sai Prakash Ranjan wrote: > On 2020-05-19 20:41, Rob Clark wrote: > > On Tue, May 19, 2020 at 2:26 AM Sai Prakash Ranjan > > wrote: > > > On 2020-05-18 21:15, Will Deacon wrote: > > > > So this sounds like an erratum to me, and I'm happy to set HUPCF if

Re: [PATCH] iomm/arm-smmu: Add stall implementation hook

2020-05-20 Thread Sai Prakash Ranjan
On 2020-05-19 20:41, Rob Clark wrote: On Tue, May 19, 2020 at 2:26 AM Sai Prakash Ranjan wrote: Hi Will, On 2020-05-18 21:15, Will Deacon wrote: > On Mon, May 11, 2020 at 11:30:08AM -0600, Jordan Crouse wrote: >> On Fri, May 08, 2020 at 08:40:40AM -0700, Rob Clark wrote: >> > On Fri, May 8,

Re: [PATCH] iomm/arm-smmu: Add stall implementation hook

2020-05-19 Thread Rob Clark
On Tue, May 19, 2020 at 2:26 AM Sai Prakash Ranjan wrote: > > Hi Will, > > On 2020-05-18 21:15, Will Deacon wrote: > > On Mon, May 11, 2020 at 11:30:08AM -0600, Jordan Crouse wrote: > >> On Fri, May 08, 2020 at 08:40:40AM -0700, Rob Clark wrote: > >> > On Fri, May 8, 2020 at 8:32 AM Rob Clark

Re: [PATCH] iomm/arm-smmu: Add stall implementation hook

2020-05-19 Thread Sai Prakash Ranjan
Hi Will, On 2020-05-18 21:15, Will Deacon wrote: On Mon, May 11, 2020 at 11:30:08AM -0600, Jordan Crouse wrote: On Fri, May 08, 2020 at 08:40:40AM -0700, Rob Clark wrote: > On Fri, May 8, 2020 at 8:32 AM Rob Clark wrote: > > > > On Thu, May 7, 2020 at 5:54 AM Will Deacon wrote: > > > > > >

Re: [PATCH] iomm/arm-smmu: Add stall implementation hook

2020-05-18 Thread Will Deacon
On Mon, May 11, 2020 at 11:30:08AM -0600, Jordan Crouse wrote: > On Fri, May 08, 2020 at 08:40:40AM -0700, Rob Clark wrote: > > On Fri, May 8, 2020 at 8:32 AM Rob Clark wrote: > > > > > > On Thu, May 7, 2020 at 5:54 AM Will Deacon wrote: > > > > > > > > On Thu, May 07, 2020 at 11:55:54AM +0100,

Re: [PATCH] iomm/arm-smmu: Add stall implementation hook

2020-05-11 Thread Jordan Crouse
On Fri, May 08, 2020 at 08:40:40AM -0700, Rob Clark wrote: > On Fri, May 8, 2020 at 8:32 AM Rob Clark wrote: > > > > On Thu, May 7, 2020 at 5:54 AM Will Deacon wrote: > > > > > > On Thu, May 07, 2020 at 11:55:54AM +0100, Robin Murphy wrote: > > > > On 2020-05-07 11:14 am, Sai Prakash Ranjan

Re: [PATCH] iomm/arm-smmu: Add stall implementation hook

2020-05-08 Thread Rob Clark
On Fri, May 8, 2020 at 8:32 AM Rob Clark wrote: > > On Thu, May 7, 2020 at 5:54 AM Will Deacon wrote: > > > > On Thu, May 07, 2020 at 11:55:54AM +0100, Robin Murphy wrote: > > > On 2020-05-07 11:14 am, Sai Prakash Ranjan wrote: > > > > On 2020-04-22 01:50, Sai Prakash Ranjan wrote: > > > > > Add

Re: [PATCH] iomm/arm-smmu: Add stall implementation hook

2020-05-08 Thread Rob Clark
On Thu, May 7, 2020 at 5:54 AM Will Deacon wrote: > > On Thu, May 07, 2020 at 11:55:54AM +0100, Robin Murphy wrote: > > On 2020-05-07 11:14 am, Sai Prakash Ranjan wrote: > > > On 2020-04-22 01:50, Sai Prakash Ranjan wrote: > > > > Add stall implementation hook to enable stalling > > > > faults on

Re: [PATCH] iomm/arm-smmu: Add stall implementation hook

2020-05-07 Thread Robin Murphy
On 2020-05-07 1:06 pm, Sai Prakash Ranjan wrote: [...] We could have our own context fault handler in QCOM implementation, but that would just be duplicating things from arm-smmu context fault handler. So I did not think it makes much sense to have our own fault handler in qcom impl just for

Re: [PATCH] iomm/arm-smmu: Add stall implementation hook

2020-05-07 Thread Will Deacon
On Thu, May 07, 2020 at 11:55:54AM +0100, Robin Murphy wrote: > On 2020-05-07 11:14 am, Sai Prakash Ranjan wrote: > > On 2020-04-22 01:50, Sai Prakash Ranjan wrote: > > > Add stall implementation hook to enable stalling > > > faults on QCOM platforms which supports it without > > > causing any

Re: [PATCH] iomm/arm-smmu: Add stall implementation hook

2020-05-07 Thread Sai Prakash Ranjan
Hi Robin, On 2020-05-07 16:25, Robin Murphy wrote: On 2020-05-07 11:14 am, Sai Prakash Ranjan wrote: Hi Will, Robin On 2020-04-22 01:50, Sai Prakash Ranjan wrote: Add stall implementation hook to enable stalling faults on QCOM platforms which supports it without causing any kind of hardware

Re: [PATCH] iomm/arm-smmu: Add stall implementation hook

2020-05-07 Thread Robin Murphy
On 2020-05-07 11:14 am, Sai Prakash Ranjan wrote: Hi Will, Robin On 2020-04-22 01:50, Sai Prakash Ranjan wrote: Add stall implementation hook to enable stalling faults on QCOM platforms which supports it without causing any kind of hardware mishaps. Without this on QCOM platforms, GPU faults

Re: [PATCH] iomm/arm-smmu: Add stall implementation hook

2020-05-07 Thread Sai Prakash Ranjan
Hi Will, Robin On 2020-04-22 01:50, Sai Prakash Ranjan wrote: Add stall implementation hook to enable stalling faults on QCOM platforms which supports it without causing any kind of hardware mishaps. Without this on QCOM platforms, GPU faults can cause unrelated GPU memory accesses to return

[PATCH] iomm/arm-smmu: Add stall implementation hook

2020-04-21 Thread Sai Prakash Ranjan
Add stall implementation hook to enable stalling faults on QCOM platforms which supports it without causing any kind of hardware mishaps. Without this on QCOM platforms, GPU faults can cause unrelated GPU memory accesses to return zeroes. This has the unfortunate result of command-stream reads