Re: [PATCH] iommu/dma: Setup iova_domain granule for IOMMU_DMA_MSI cookies

2017-05-16 Thread Auger Eric
Hi Nate, On 16/05/2017 22:07, Nate Watterson wrote: > > > On 5/16/2017 3:55 PM, Auger Eric wrote: >> Hi, >> >> On 13/04/2017 21:38, Nate Watterson wrote: >>> Hi Robin, >>> >>> On 4/13/2017 7:21 AM, Robin Murphy wrote: Hi Nate, On 13/04/17 09:55, Nate Watterson wrote: >

Re: [PATCH] iommu/dma: Setup iova_domain granule for IOMMU_DMA_MSI cookies

2017-05-16 Thread Nate Watterson
On 5/16/2017 3:55 PM, Auger Eric wrote: Hi, On 13/04/2017 21:38, Nate Watterson wrote: Hi Robin, On 4/13/2017 7:21 AM, Robin Murphy wrote: Hi Nate, On 13/04/17 09:55, Nate Watterson wrote: Currently, the __iommu_dma_{map/free} functions call iova_{offset/align} making them unsuitable for

Re: [PATCH] iommu/dma: Setup iova_domain granule for IOMMU_DMA_MSI cookies

2017-05-16 Thread Auger Eric
Hi, On 13/04/2017 21:38, Nate Watterson wrote: > Hi Robin, > > On 4/13/2017 7:21 AM, Robin Murphy wrote: >> Hi Nate, >> >> On 13/04/17 09:55, Nate Watterson wrote: >>> Currently, the __iommu_dma_{map/free} functions call iova_{offset/align} >>> making them unsuitable for use with iommu_domains

RE: [PATCH] iommu/dma: Setup iova_domain granule for IOMMU_DMA_MSI cookies

2017-05-04 Thread Bharat Bhushan
undation.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH] iommu/dma: Setup iova_domain granule for > IOMMU_DMA_MSI cookies > > Hi Robin, > > I tested your changes and the device pass-through feature works fine on > QDF2400 server platform. Maybe Nate comments on the patch

Re: [PATCH] iommu/dma: Setup iova_domain granule for IOMMU_DMA_MSI cookies

2017-04-13 Thread Nate Watterson
Hi Robin, On 4/13/2017 7:21 AM, Robin Murphy wrote: Hi Nate, On 13/04/17 09:55, Nate Watterson wrote: Currently, the __iommu_dma_{map/free} functions call iova_{offset/align} making them unsuitable for use with iommu_domains having an IOMMU_DMA_MSI cookie since the cookie's iova_domain

Re: [PATCH] iommu/dma: Setup iova_domain granule for IOMMU_DMA_MSI cookies

2017-04-13 Thread Shanker Donthineni
Hi Robin, I tested your changes and the device pass-through feature works fine on QDF2400 server platform. Maybe Nate comments on the patch contents but it fixes the problem. @@ -317,13 +317,13 @@ static void iommu_dma_free_iova(struct iommu_dma_cookie *cookie, dma_addr_t

Re: [PATCH] iommu/dma: Setup iova_domain granule for IOMMU_DMA_MSI cookies

2017-04-13 Thread Robin Murphy
Hi Nate, On 13/04/17 09:55, Nate Watterson wrote: > Currently, the __iommu_dma_{map/free} functions call iova_{offset/align} > making them unsuitable for use with iommu_domains having an IOMMU_DMA_MSI > cookie since the cookie's iova_domain member, iovad, is uninitialized. > > Now that

[PATCH] iommu/dma: Setup iova_domain granule for IOMMU_DMA_MSI cookies

2017-04-13 Thread Nate Watterson
Currently, the __iommu_dma_{map/free} functions call iova_{offset/align} making them unsuitable for use with iommu_domains having an IOMMU_DMA_MSI cookie since the cookie's iova_domain member, iovad, is uninitialized. Now that iommu_dma_get_msi_page() calls __iommu_dma_map() regardless of cookie