Re: [PATCH] iommu/iova: validate iova_domain input to put_iova_domain

2016-07-14 Thread nwatters
On 2016-07-14 07:21, Auger Eric wrote: Hi Robin, Nate, On 14/07/2016 12:36, Robin Murphy wrote: On 14/07/16 09:34, Joerg Roedel wrote: On Wed, Jul 13, 2016 at 02:49:32PM -0400, Nate Watterson wrote: Passing a NULL or uninitialized iova_domain into put_iova_domain will currently crash the

Re: [PATCH] iommu/iova: validate iova_domain input to put_iova_domain

2016-07-14 Thread Auger Eric
Hi Robin, Nate, On 14/07/2016 12:36, Robin Murphy wrote: > On 14/07/16 09:34, Joerg Roedel wrote: >> On Wed, Jul 13, 2016 at 02:49:32PM -0400, Nate Watterson wrote: >>> Passing a NULL or uninitialized iova_domain into put_iova_domain >>> will currently crash the kernel when the unconfigured

Re: [PATCH] iommu/iova: validate iova_domain input to put_iova_domain

2016-07-14 Thread Robin Murphy
On 14/07/16 09:34, Joerg Roedel wrote: > On Wed, Jul 13, 2016 at 02:49:32PM -0400, Nate Watterson wrote: >> Passing a NULL or uninitialized iova_domain into put_iova_domain >> will currently crash the kernel when the unconfigured iova_domain >> data members are accessed. To prevent this from

Re: [PATCH] iommu/iova: validate iova_domain input to put_iova_domain

2016-07-14 Thread Joerg Roedel
On Wed, Jul 13, 2016 at 02:49:32PM -0400, Nate Watterson wrote: > Passing a NULL or uninitialized iova_domain into put_iova_domain > will currently crash the kernel when the unconfigured iova_domain > data members are accessed. To prevent this from occurring, this patch > adds a check to make sure

[PATCH] iommu/iova: validate iova_domain input to put_iova_domain

2016-07-13 Thread Nate Watterson
Passing a NULL or uninitialized iova_domain into put_iova_domain will currently crash the kernel when the unconfigured iova_domain data members are accessed. To prevent this from occurring, this patch adds a check to make sure that the domain is non-NULL and that the domain granule is non-zero.