Re: [PATCH] iommu/qcom: Simplify a test in 'qcom_iommu_add_device()'

2019-10-15 Thread Joerg Roedel
On Mon, Sep 16, 2019 at 10:29:36PM +0200, Christophe JAILLET wrote: > 'iommu_group_get_for_dev()' never returns NULL, so this test can be > simplified a bit. > > This way, the test is consistent with all other calls to > 'iommu_group_get_for_dev()'. > > Signed-off-by: Christophe JAILLET > --- >

Re: [PATCH] iommu/qcom: Simplify a test in 'qcom_iommu_add_device()'

2019-09-17 Thread Dan Carpenter
On Mon, Sep 16, 2019 at 10:29:36PM +0200, Christophe JAILLET wrote: > 'iommu_group_get_for_dev()' never returns NULL, so this test can be > simplified a bit. > It used to until commit 72dcac633475 ("iommu: Warn once when device_group callback returns NULL"). Reviewed-by: Dan Carpenter

[PATCH] iommu/qcom: Simplify a test in 'qcom_iommu_add_device()'

2019-09-16 Thread Christophe JAILLET
'iommu_group_get_for_dev()' never returns NULL, so this test can be simplified a bit. This way, the test is consistent with all other calls to 'iommu_group_get_for_dev()'. Signed-off-by: Christophe JAILLET --- drivers/iommu/qcom_iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)