Re: [PATCH] iommu/vt-d: Fix PCI bus rescan device hot add

2022-07-06 Thread Joerg Roedel
On Fri, Jun 24, 2022 at 02:12:28PM +0800, Baolu Lu wrote: > It makes sense as far as I am aware. By putting IOMMUs in pass-through > mode, there will be no run-time costs and things could be simplified a > lot. > > Besides the refactoring efforts, we still need this quick fix so that > the fix cou

Re: [PATCH] iommu/vt-d: Fix PCI bus rescan device hot add

2022-06-23 Thread Baolu Lu
Hi Joerg, On 2022/6/24 13:45, Joerg Roedel wrote: Hi Baolu, On Wed, May 25, 2022 at 09:40:26AM +0800, Baolu Lu wrote: How do you like it? If you agree, I can queue it in my next pull request for fixes. Would it help to tie DMAR and IOMMU components together, so that selecting DMAR for IRQ re

Re: [PATCH] iommu/vt-d: Fix PCI bus rescan device hot add

2022-06-23 Thread Joerg Roedel
Hi Baolu, On Wed, May 25, 2022 at 09:40:26AM +0800, Baolu Lu wrote: > How do you like it? If you agree, I can queue it in my next pull request > for fixes. Would it help to tie DMAR and IOMMU components together, so that selecting DMAR for IRQ remapping also selects IOMMU? The IOMMU can be in PT

Re: [PATCH] iommu/vt-d: Fix PCI bus rescan device hot add

2022-05-24 Thread Baolu Lu
Hi Joerg, On 2022/5/21 08:21, Yian Chen wrote: Notifier calling chain uses priority to determine the execution order of the notifiers or listeners registered to the chain. PCI bus device hot add utilizes the notification mechanism. The current code sets low priority (INT_MIN) to Intel dmar_pci_

[PATCH] iommu/vt-d: Fix PCI bus rescan device hot add

2022-05-20 Thread Yian Chen
Notifier calling chain uses priority to determine the execution order of the notifiers or listeners registered to the chain. PCI bus device hot add utilizes the notification mechanism. The current code sets low priority (INT_MIN) to Intel dmar_pci_bus_notifier and postpones DMAR decoding after add

Re: [PATCH] iommu/vt-d: Fix PCI bus rescan device hot add

2022-01-14 Thread Jacob Pan
Hi Lu, On Fri, 14 Jan 2022 11:12:45 +0800, Lu Baolu wrote: > On 1/14/22 11:11 AM, Jacob Pan wrote: > > On Fri, 14 Jan 2022 08:58:53 +0800, Lu Baolu > > wrote: > > > >> Hi Jacob, > >> > >> On 1/13/22 9:23 PM, Jacob Pan wrote: > >>> During PCI bus rescan, adding new devices involve two notifi

Re: [PATCH] iommu/vt-d: Fix PCI bus rescan device hot add

2022-01-13 Thread Lu Baolu
On 1/14/22 11:11 AM, Jacob Pan wrote: On Fri, 14 Jan 2022 08:58:53 +0800, Lu Baolu wrote: Hi Jacob, On 1/13/22 9:23 PM, Jacob Pan wrote: During PCI bus rescan, adding new devices involve two notifiers. 1. dmar_pci_bus_notifier() 2. iommu_bus_notifier() The current code sets #1 as low priority

Re: [PATCH] iommu/vt-d: Fix PCI bus rescan device hot add

2022-01-13 Thread Jacob Pan
Hi BaoLu, On Fri, 14 Jan 2022 08:58:53 +0800, Lu Baolu wrote: > Hi Jacob, > > On 1/13/22 9:23 PM, Jacob Pan wrote: > > During PCI bus rescan, adding new devices involve two notifiers. > > 1. dmar_pci_bus_notifier() > > 2. iommu_bus_notifier() > > The current code sets #1 as low priority (INT_MI

Re: [PATCH] iommu/vt-d: Fix PCI bus rescan device hot add

2022-01-13 Thread Lu Baolu
Hi Jacob, On 1/13/22 9:23 PM, Jacob Pan wrote: During PCI bus rescan, adding new devices involve two notifiers. 1. dmar_pci_bus_notifier() 2. iommu_bus_notifier() The current code sets #1 as low priority (INT_MIN) which resulted in #2 being invoked first. The result is that struct device pointer

[PATCH] iommu/vt-d: Fix PCI bus rescan device hot add

2022-01-13 Thread Jacob Pan
During PCI bus rescan, adding new devices involve two notifiers. 1. dmar_pci_bus_notifier() 2. iommu_bus_notifier() The current code sets #1 as low priority (INT_MIN) which resulted in #2 being invoked first. The result is that struct device pointer cannot be found in DRHD search for the new device