Re: [PATCH] iommu/vt-d: Fix an off-by-one bug in __domain_mapping()

2014-12-02 Thread David Woodhouse
On Mon, 2014-12-01 at 17:27 +0100, Joerg Roedel wrote: On Wed, Nov 26, 2014 at 09:42:10AM +0800, Jiang Liu wrote: There's an off-by-one bug in function __domain_mapping(), which may trigger the BUG_ON(nr_pages lvl_pages) when (nr_pages + 1) superpage_mask == 0 What is the

Re: [PATCH] iommu/vt-d: Fix an off-by-one bug in __domain_mapping()

2014-12-02 Thread Joerg Roedel
On Tue, Dec 02, 2014 at 10:34:35AM +, David Woodhouse wrote: __domain_mapping() is an amalgamation of the old domain_pfn_mapping() and domain_sg_mapping() functions. When I did that, in commit 9051aa026, the 'sg_res' variable was used *only* for tracking how many pages were left in the

Re: [PATCH] iommu/vt-d: Fix an off-by-one bug in __domain_mapping()

2014-12-01 Thread Joerg Roedel
On Wed, Nov 26, 2014 at 09:42:10AM +0800, Jiang Liu wrote: There's an off-by-one bug in function __domain_mapping(), which may trigger the BUG_ON(nr_pages lvl_pages) when (nr_pages + 1) superpage_mask == 0 What is the superpage_mask? The issue was introduced by commit 9051aa0268dc

[PATCH] iommu/vt-d: Fix an off-by-one bug in __domain_mapping()

2014-11-25 Thread Jiang Liu
There's an off-by-one bug in function __domain_mapping(), which may trigger the BUG_ON(nr_pages lvl_pages) when (nr_pages + 1) superpage_mask == 0 The issue was introduced by commit 9051aa0268dc intel-iommu: Combine domain_pfn_mapping() and domain_sg_mapping(), which sets sg_res to