Re: [PATCH] iommu: Check return of __iommu_attach_device()

2020-11-23 Thread Will Deacon
On Thu, 19 Nov 2020 16:58:46 +, Shameer Kolothum wrote: > Currently iommu_create_device_direct_mappings() is called > without checking the return of __iommu_attach_device(). This > may result in failures in iommu driver if dev attach returns > error. Applied to arm64 (for-next/iommu/fixes),

RE: [PATCH] iommu: Check return of __iommu_attach_device()

2020-11-20 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Robin Murphy [mailto:robin.mur...@arm.com] > Sent: 20 November 2020 14:07 > To: Will Deacon ; Shameerali Kolothum Thodi > > Cc: linux-arm-ker...@lists.infradead.org; iommu@lists.linux-foundation.org; > Linuxarm > Subject: Re: [PA

Re: [PATCH] iommu: Check return of __iommu_attach_device()

2020-11-20 Thread Robin Murphy
On 2020-11-20 11:15, Will Deacon wrote: On Thu, Nov 19, 2020 at 04:58:46PM +, Shameer Kolothum wrote: Currently iommu_create_device_direct_mappings() is called without checking the return of __iommu_attach_device(). This may result in failures in iommu driver if dev attach returns error.

Re: [PATCH] iommu: Check return of __iommu_attach_device()

2020-11-20 Thread Will Deacon
On Thu, Nov 19, 2020 at 04:58:46PM +, Shameer Kolothum wrote: > Currently iommu_create_device_direct_mappings() is called > without checking the return of __iommu_attach_device(). This > may result in failures in iommu driver if dev attach returns > error. > > Fixes: ce574c27ae27("iommu: Move

[PATCH] iommu: Check return of __iommu_attach_device()

2020-11-19 Thread Shameer Kolothum
Currently iommu_create_device_direct_mappings() is called without checking the return of __iommu_attach_device(). This may result in failures in iommu driver if dev attach returns error. Fixes: ce574c27ae27("iommu: Move iommu_group_create_direct_mappings() out of iommu_group_add_device()")