Re: [PATCH] iommu: Clarify .of_xlate assumptions

2020-10-30 Thread Marek Szyprowski
Hi Robin, On 29.10.2020 16:34, Robin Murphy wrote: > A common idiom for .of_xlate is to use of_find_device_by_node() to > retrieve the relevant IOMMU instance data when translating IOMMU > specifiers for a client device. Although it's slightly roundabout, > this is simply looking up something we

Re: [PATCH] iommu: Clarify .of_xlate assumptions

2020-10-29 Thread Maxime Ripard
On Thu, Oct 29, 2020 at 03:34:48PM +, Robin Murphy wrote: > A common idiom for .of_xlate is to use of_find_device_by_node() to > retrieve the relevant IOMMU instance data when translating IOMMU > specifiers for a client device. Although it's slightly roundabout, > this is simply looking up

[PATCH] iommu: Clarify .of_xlate assumptions

2020-10-29 Thread Robin Murphy
A common idiom for .of_xlate is to use of_find_device_by_node() to retrieve the relevant IOMMU instance data when translating IOMMU specifiers for a client device. Although it's slightly roundabout, this is simply looking up something we know exists - if it *were* to return NULL, that would mean