Re: [PATCH] sparc: use generic dma_noncoherent_ops

2018-07-30 Thread Sam Ravnborg
Hi Christoph. On Mon, Jul 30, 2018 at 06:17:23PM +0200, Christoph Hellwig wrote: > Switch to the generic noncoherent direct mapping implementation. > > This removes the previous sync_single_for_device implementation, which > looks bogus given that no syncing is happening in the similar but more

[PATCH] sparc: use generic dma_noncoherent_ops

2018-07-30 Thread Christoph Hellwig
Switch to the generic noncoherent direct mapping implementation. This removes the previous sync_single_for_device implementation, which looks bogus given that no syncing is happening in the similar but more important map_single case. Signed-off-by: Christoph Hellwig Acked-by: Sam Ravnborg ---

Re: [PATCH] sparc: use generic dma_noncoherent_ops

2018-07-30 Thread Christoph Hellwig
On Fri, Jul 27, 2018 at 11:05:48PM +0200, Sam Ravnborg wrote: > Hi Christoph. > > Some observations below - nitpick and bikeshedding only. > > The parameter of phys_addr_t is sometimes renamed > to use the same name as in the original prototype (good), > and sometimes uses the old name (bad). >

Re: [PATCH] sparc: use generic dma_noncoherent_ops

2018-07-27 Thread Sam Ravnborg
Hi Christoph. Some observations below - nitpick and bikeshedding only. The parameter of phys_addr_t is sometimes renamed to use the same name as in the original prototype (good), and sometimes uses the old name (bad). This makes it inconsistent as the local name changes in the different

[PATCH] sparc: use generic dma_noncoherent_ops

2018-07-27 Thread Christoph Hellwig
Switch to the generic noncoherent direct mapping implementation. This removes the previous sync_single_for_device implementation, which looks bogus given that no syncing is happening in the similar but more important map_single case. Signed-off-by: Christoph Hellwig --- arch/sparc/Kconfig