Hi Joerg,
I love your patch! Perhaps something to improve:
[auto build test WARNING on swiotlb/linux-next]
[also build test WARNING on v5.0-rc4]
[cannot apply to next-20190201]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
On Fri, Feb 01, 2019 at 05:59:01PM +0100, Joerg Roedel wrote:
> > > This sounds like a change to break quite a couple of places in the
> > > kernel. But okay, it just makes this hunk obsolete.
> >
> > He also added either explicit panic calls or error handling (panic
> > in case of swiotlb):
> >
On Fri, Feb 01, 2019 at 05:56:10PM +0100, Christoph Hellwig wrote:
> On Fri, Feb 01, 2019 at 05:50:29PM +0100, Joerg Roedel wrote:
> > > Mike just killed the _nopanic versions and made the normal ones not
> > > panic.
> >
> > This sounds like a change to break quite a couple of places in the
> >
On Fri, Feb 01, 2019 at 05:50:29PM +0100, Joerg Roedel wrote:
> > Mike just killed the _nopanic versions and made the normal ones not
> > panic.
>
> This sounds like a change to break quite a couple of places in the
> kernel. But okay, it just makes this hunk obsolete.
He also added either
On Fri, Feb 01, 2019 at 09:12:08AM +0100, Christoph Hellwig wrote:
> On Thu, Jan 31, 2019 at 05:24:24PM +0100, Joerg Roedel wrote:
> > - io_tlb_list = memblock_alloc(
> > + io_tlb_list = memblock_alloc_nopanic(
> > PAGE_ALIGN(io_tlb_nslabs * sizeof(int)),
> >
On Thu, Jan 31, 2019 at 05:24:24PM +0100, Joerg Roedel wrote:
> From: Joerg Roedel
>
> The only reason why swiotlb_init_with_tbl() can fail is an
> allocation failure in the memblock_alloc() function. But
> this function just calls panic() in case it can't fulfill
> the request and never returns
From: Joerg Roedel
The only reason why swiotlb_init_with_tbl() can fail is an
allocation failure in the memblock_alloc() function. But
this function just calls panic() in case it can't fulfill
the request and never returns an error, therefore
swiotlb_init_with_tbl() also never actually returns
