Re: [PATCH 0/2] Fix ACS path checking

2012-08-06 Thread Joerg Roedel
On Sat, Aug 04, 2012 at 12:08:46PM -0600, Alex Williamson wrote: Joerg, I notice that ACS isn't getting enabled on my AMD system on 3.6-rc1. I'll investigate more, but mention it in case you get to it first. Hmm, tried it here, At least pci_request_acs() still gets called. How do you detect

Re: [PATCH 0/2] Fix ACS path checking

2012-08-06 Thread Joerg Roedel
On Mon, Aug 06, 2012 at 12:50:10PM +0200, Joerg Roedel wrote: On Sat, Aug 04, 2012 at 12:08:46PM -0600, Alex Williamson wrote: Hmm, tried it here, At least pci_request_acs() still gets called. How do you detect if ACS is really enabled? Okay, I found a problem. pci_request_acs needs to be

Re: [PATCH 0/2] Fix ACS path checking

2012-08-06 Thread Alex Williamson
On Mon, 2012-08-06 at 14:20 +0200, Joerg Roedel wrote: On Mon, Aug 06, 2012 at 12:50:10PM +0200, Joerg Roedel wrote: On Sat, Aug 04, 2012 at 12:08:46PM -0600, Alex Williamson wrote: Hmm, tried it here, At least pci_request_acs() still gets called. How do you detect if ACS is really enabled?

Re: [PATCH 0/2] Fix ACS path checking

2012-08-06 Thread Joerg Roedel
On Sat, Aug 04, 2012 at 12:08:46PM -0600, Alex Williamson wrote: Alex Williamson (2): amd-iommu: Fix ACS path checking intel-iommu: Fix ACS path checking Applied these two patches together with my ACS fix to iommu/fixes, thanks. -- AMD Operating System Research Center Advanced

[PATCH 0/2] Fix ACS path checking

2012-08-04 Thread Alex Williamson
David Ahern reported an oops caused by passing a NULL start device to pci_acs_path_enabled(). This can happen when a bus is created for sr-iov devices without an associated bridge. To handle this, skip over to the parent bus and look for a bridge there. Continue until we find something or reach