Re: [PATCH 06/10] dma-direct: refactor the !coherent checks in dma_direct_alloc

2021-11-09 Thread Christoph Hellwig
On Thu, Nov 04, 2021 at 12:36:08PM +, Robin Murphy wrote: > How about: > remap = IS_ENABLED(CONFIG_DMA_DIRECT_REMAP); > > if (remap && ...) > > for a bit less indentation? FWIW I reckon it's slightly more obvious that > way round. Done.

Re: [PATCH 06/10] dma-direct: refactor the !coherent checks in dma_direct_alloc

2021-11-04 Thread Robin Murphy
On 2021-10-21 10:06, Christoph Hellwig wrote: Add a big central !dev_is_dma_coherent(dev) block to deal with as much as of the uncached allocation schemes and document the schemes a bit better. Signed-off-by: Christoph Hellwig --- kernel/dma/direct.c | 58 -

[PATCH 06/10] dma-direct: refactor the !coherent checks in dma_direct_alloc

2021-10-21 Thread Christoph Hellwig
Add a big central !dev_is_dma_coherent(dev) block to deal with as much as of the uncached allocation schemes and document the schemes a bit better. Signed-off-by: Christoph Hellwig --- kernel/dma/direct.c | 58 - 1 file changed, 36 insertions(+), 22 de