Re: [PATCH 1/2] vfio/type1: Simplify bus_type determination

2022-06-24 Thread Jason Gunthorpe via iommu
On Tue, Jun 21, 2022 at 08:09:20PM +0100, Robin Murphy wrote: > Quick consensus then: does anyone have a particular preference between > changing the .attach_group signature vs. adding a helper based on > vfio_group_get_from_iommu() for type1 to call from within its callback? They > seem about

Re: [PATCH 1/2] vfio/type1: Simplify bus_type determination

2022-06-21 Thread Robin Murphy
On 2022-06-10 01:03, Jason Gunthorpe via iommu wrote: On Wed, Jun 08, 2022 at 03:25:49PM +0100, Robin Murphy wrote: Since IOMMU groups are mandatory for drivers to support, it stands to reason that any device which has been successfully be added to a group must be on a bus supported by that

Re: [PATCH 1/2] vfio/type1: Simplify bus_type determination

2022-06-09 Thread Jason Gunthorpe via iommu
On Wed, Jun 08, 2022 at 03:25:49PM +0100, Robin Murphy wrote: > Since IOMMU groups are mandatory for drivers to support, it stands to > reason that any device which has been successfully be added to a group > must be on a bus supported by that IOMMU driver, and therefore a domain > viable for any

[PATCH 1/2] vfio/type1: Simplify bus_type determination

2022-06-08 Thread Robin Murphy
Since IOMMU groups are mandatory for drivers to support, it stands to reason that any device which has been successfully be added to a group must be on a bus supported by that IOMMU driver, and therefore a domain viable for any device in the group must be viable for all devices in the group. This