[PATCH 2/4] iommu: Consolitate ->add/remove_device() calls

2018-12-11 Thread Joerg Roedel
From: Joerg Roedel Put them into separate functions and call those where the plain ops have been called before. Signed-off-by: Joerg Roedel --- drivers/iommu/iommu.c | 51 +-- include/linux/iommu.h | 3 +++ 2 files changed, 28 insertions(+), 26

Re: [PATCH 2/4] iommu: Consolitate ->add/remove_device() calls

2018-12-06 Thread Joerg Roedel
On Wed, Dec 05, 2018 at 06:20:50PM +, Robin Murphy wrote: > Is there any good reason to let .add_device/.remove_device be optional > still? Everyone's implemented them for a while now, and on a practical level > I don't really see how else we could expect devices to be taken in and out > of

Re: [PATCH 2/4] iommu: Consolitate ->add/remove_device() calls

2018-12-05 Thread Robin Murphy
On 05/12/2018 14:36, Joerg Roedel wrote: From: Joerg Roedel Put them into separate functions and call those where the plain ops have been called before. Signed-off-by: Joerg Roedel --- drivers/iommu/iommu.c | 54 ++- include/linux/iommu.h | 3 +++

Re: [PATCH 2/4] iommu: Consolitate ->add/remove_device() calls

2018-12-05 Thread Joerg Roedel
On Wed, Dec 05, 2018 at 06:54:18AM -0800, Christoph Hellwig wrote: > > +void iommu_release_device(struct device *dev) > > Nitpick: there seems to be a double space here. > > > +int iommu_probe_device(struct device *dev); > > +void iommu_release_device(struct device *dev); > > .. and here.

Re: [PATCH 2/4] iommu: Consolitate ->add/remove_device() calls

2018-12-05 Thread Christoph Hellwig
> +void iommu_release_device(struct device *dev) Nitpick: there seems to be a double space here. > +int iommu_probe_device(struct device *dev); > +void iommu_release_device(struct device *dev); .. and here. ___ iommu mailing list

[PATCH 2/4] iommu: Consolitate ->add/remove_device() calls

2018-12-05 Thread Joerg Roedel
From: Joerg Roedel Put them into separate functions and call those where the plain ops have been called before. Signed-off-by: Joerg Roedel --- drivers/iommu/iommu.c | 54 ++- include/linux/iommu.h | 3 +++ 2 files changed, 31 insertions(+), 26