Re: [PATCH 3/4] iommu/of: Don't call iommu_ops->add_device directly

2019-01-11 Thread Joerg Roedel
Hi Geert, On Thu, Dec 20, 2018 at 04:42:17PM +0100, Geert Uytterhoeven wrote: > > - return ops->add_device(dev); > > + if (ops) > > Is this sufficient? The old code checked for ops->add_device != NULL, > too. Robin brought up that all iommu-ops implementations support the

Re: [PATCH 3/4] iommu/of: Don't call iommu_ops->add_device directly

2018-12-20 Thread Geert Uytterhoeven
Hi Jörg, On Wed, Dec 19, 2018 at 5:51 PM Joerg Roedel wrote: > On Wed, Dec 19, 2018 at 10:54:18AM +0100, Marek Szyprowski wrote: > > On 2018-12-11 16:05, Joerg Roedel wrote: > > > From: Joerg Roedel > > > > > > Make sure to invoke this call-back through the proper > > > function of the

Re: [PATCH 3/4] iommu/of: Don't call iommu_ops->add_device directly

2018-12-20 Thread Joerg Roedel
Hi Marek, On Wed, Dec 19, 2018 at 03:53:51PM +0100, Marek Szyprowski wrote: > Yes, it fixes this issue. Thanks a lot, patch is sent out and in iommu tree. Regards, Joerg ___ iommu mailing list iommu@lists.linux-foundation.org

Re: [PATCH 3/4] iommu/of: Don't call iommu_ops->add_device directly

2018-12-19 Thread Marek Szyprowski
Hi Joerg, On 2018-12-19 15:34, Joerg Roedel wrote: > Hi Marek, > > thanks for the report! > > On Wed, Dec 19, 2018 at 10:54:18AM +0100, Marek Szyprowski wrote: >> On 2018-12-11 16:05, Joerg Roedel wrote: >>> From: Joerg Roedel >>> >>> Make sure to invoke this call-back through the proper >>>

Re: [PATCH 3/4] iommu/of: Don't call iommu_ops->add_device directly

2018-12-19 Thread Joerg Roedel
Hi Marek, thanks for the report! On Wed, Dec 19, 2018 at 10:54:18AM +0100, Marek Szyprowski wrote: > On 2018-12-11 16:05, Joerg Roedel wrote: > > From: Joerg Roedel > > > > Make sure to invoke this call-back through the proper > > function of the IOMMU-API. > > > > Signed-off-by: Joerg Roedel

Re: [PATCH 3/4] iommu/of: Don't call iommu_ops->add_device directly

2018-12-19 Thread Marek Szyprowski
Hi Joerg, This patch landed in today's linux-next and causes a regression. On 2018-12-11 16:05, Joerg Roedel wrote: > From: Joerg Roedel > > Make sure to invoke this call-back through the proper > function of the IOMMU-API. > > Signed-off-by: Joerg Roedel > --- > drivers/iommu/of_iommu.c | 6

[PATCH 3/4] iommu/of: Don't call iommu_ops->add_device directly

2018-12-11 Thread Joerg Roedel
From: Joerg Roedel Make sure to invoke this call-back through the proper function of the IOMMU-API. Signed-off-by: Joerg Roedel --- drivers/iommu/of_iommu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c index

Re: [PATCH 3/4] iommu/of: Don't call iommu_ops->add_device directly

2018-12-06 Thread Joerg Roedel
On Wed, Dec 05, 2018 at 06:49:26PM +, Robin Murphy wrote: > if (ops && dev->bus && !dev->iommu_group) > > What I can't quite remember just now is whether it's actually valid to get > here with err == 0 but dev->iommu_fwspec->ops == NULL, so it *might* be OK > to use "!err" instead of

Re: [PATCH 3/4] iommu/of: Don't call iommu_ops->add_device directly

2018-12-05 Thread Robin Murphy
On 05/12/2018 14:36, Joerg Roedel wrote: From: Joerg Roedel Make sure to invoke this call-back through the proper function of the IOMMU-API. Signed-off-by: Joerg Roedel --- drivers/iommu/of_iommu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 3/4] iommu/of: Don't call iommu_ops->add_device directly

2018-12-05 Thread Joerg Roedel
From: Joerg Roedel Make sure to invoke this call-back through the proper function of the IOMMU-API. Signed-off-by: Joerg Roedel --- drivers/iommu/of_iommu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c index