Re: [PATCH 3/4] iommu: remove the put_resv_regions method

2022-07-10 Thread Will Deacon
On Fri, Jul 08, 2022 at 12:19:51PM +0200, Christoph Hellwig wrote: > On Fri, Jul 08, 2022 at 11:12:45AM +0100, Will Deacon wrote: > > Heads up, but I think this might collide (trivially?) with: > > > > https://lore.kernel.org/r/20220615101044.1972-1-shameerali.kolothum.th...@huawei.com > > > >

Re: [PATCH 3/4] iommu: remove the put_resv_regions method

2022-07-10 Thread Christoph Hellwig
On Fri, Jul 08, 2022 at 05:00:59PM +0800, Baolu Lu wrote: > Do we really need to export this symbol? It is not used beyond the iommu > core code. virtio-iommu calls it and can be modular. ___ iommu mailing list iommu@lists.linux-foundation.org

Re: [PATCH 3/4] iommu: remove the put_resv_regions method

2022-07-10 Thread Christoph Hellwig
On Fri, Jul 08, 2022 at 11:12:45AM +0100, Will Deacon wrote: > Heads up, but I think this might collide (trivially?) with: > > https://lore.kernel.org/r/20220615101044.1972-1-shameerali.kolothum.th...@huawei.com > > which Joerg has queued up already. It looks like the cleanup still makes > sense

Re: [PATCH 3/4] iommu: remove the put_resv_regions method

2022-07-10 Thread Baolu Lu
On 2022/7/8 17:33, Christoph Hellwig wrote: On Fri, Jul 08, 2022 at 05:00:59PM +0800, Baolu Lu wrote: Do we really need to export this symbol? It is not used beyond the iommu core code. virtio-iommu calls it and can be modular. Yes. Thanks for the explanation. Reviewed-by: Lu Baolu Best

Re: [PATCH 3/4] iommu: remove the put_resv_regions method

2022-07-10 Thread Will Deacon
On Fri, Jul 08, 2022 at 10:06:15AM +0200, Christoph Hellwig wrote: > All drivers that implement get_resv_regions just use > generic_put_resv_regions to implement the put side. Remove the > indirections and document the allocations constraints. > > Signed-off-by: Christoph Hellwig > --- >

[PATCH 3/4] iommu: remove the put_resv_regions method

2022-07-10 Thread Christoph Hellwig
All drivers that implement get_resv_regions just use generic_put_resv_regions to implement the put side. Remove the indirections and document the allocations constraints. Signed-off-by: Christoph Hellwig --- drivers/iommu/amd/iommu.c | 1 - drivers/iommu/apple-dart.c

Re: [PATCH 3/4] iommu: remove the put_resv_regions method

2022-07-10 Thread Baolu Lu
On 2022/7/8 16:06, Christoph Hellwig wrote: -void generic_iommu_put_resv_regions(struct device *dev, struct list_head *list) +void iommu_put_resv_regions(struct device *dev, struct list_head *list) { struct iommu_resv_region *entry, *next; @@ -2610,7 +2597,7 @@ void

Re: [PATCH 3/4] iommu: remove the put_resv_regions method

2022-04-07 Thread Christoph Hellwig
On Thu, Apr 07, 2022 at 11:18:20AM +0100, Robin Murphy wrote: > On 2022-04-07 07:26, Christoph Hellwig wrote: >> All drivers that implement get_resv_regions just use >> generic_put_resv_regions to implement the put side. Remove the >> indirections and document the allocations constraints. > >

Re: [PATCH 3/4] iommu: remove the put_resv_regions method

2022-04-07 Thread Robin Murphy
On 2022-04-07 07:26, Christoph Hellwig wrote: All drivers that implement get_resv_regions just use generic_put_resv_regions to implement the put side. Remove the indirections and document the allocations constraints. Unfortunately we need to keep this one for now, as the belated IORT RMR

RE: [PATCH 3/4] iommu: remove the put_resv_regions method

2022-04-07 Thread Tian, Kevin
> From: Christoph Hellwig > Sent: Thursday, April 7, 2022 2:26 PM > > All drivers that implement get_resv_regions just use > generic_put_resv_regions to implement the put side. Remove the > indirections and document the allocations constraints. > Looks no document after removal: > void

[PATCH 3/4] iommu: remove the put_resv_regions method

2022-04-07 Thread Christoph Hellwig
All drivers that implement get_resv_regions just use generic_put_resv_regions to implement the put side. Remove the indirections and document the allocations constraints. Signed-off-by: Christoph Hellwig --- drivers/iommu/amd/iommu.c | 1 - drivers/iommu/apple-dart.c