Re: [PATCH 4/7] mfd: hi655x: Add hi665x pmic driver

2015-11-06 Thread Andy Shevchenko
On Thu, Nov 5, 2015 at 3:34 PM, Chen Feng wrote: > Add pmic driver to support hisilicon hi665x pmic. > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include >

Re: [PATCH 4/7] mfd: hi655x: Add hi665x pmic driver

2015-11-05 Thread Mark Brown
On Thu, Nov 05, 2015 at 09:34:45PM +0800, Chen Feng wrote: > +config MFD_HI655X_PMIC > +bool "HiSilicon Hi655X series PMU/Codec IC" Why is this bool and not tristate? > +depends on ARCH_HISI Can we have an || COMPILE_TEST here? > +static irqreturn_t hi655x_pmic_irq_handler(int

[PATCH 4/7] mfd: hi655x: Add hi665x pmic driver

2015-11-05 Thread Chen Feng
Add pmic driver to support hisilicon hi665x pmic. Signed-off-by: Chen Feng Signed-off-by: Fei Wang --- drivers/mfd/Kconfig | 9 ++ drivers/mfd/Makefile| 1 + drivers/mfd/hi655x-pmic.c | 315