Re: [PATCH 4/9] memory: mtk-smi: Rename smi_gen to smi_type

2021-07-11 Thread Yong Wu
On Thu, 2021-07-08 at 11:34 +0200, Krzysztof Kozlowski wrote: > On 16/06/2021 13:43, Yong Wu wrote: > > This is a preparing patch for adding smi sub common. > > Don't write "This patch". Use simple imperative: > "Prepare for adding smi sub common." > > https://elixir.bootlin.com/linux/v5.13/sourc

Re: [PATCH 4/9] memory: mtk-smi: Rename smi_gen to smi_type

2021-07-08 Thread Krzysztof Kozlowski
On 16/06/2021 13:43, Yong Wu wrote: > This is a preparing patch for adding smi sub common. Don't write "This patch". Use simple imperative: "Prepare for adding smi sub common." https://elixir.bootlin.com/linux/v5.13/source/Documentation/process/submitting-patches.rst#L89 > About the previou smi

[PATCH 4/9] memory: mtk-smi: Rename smi_gen to smi_type

2021-06-16 Thread Yong Wu
This is a preparing patch for adding smi sub common. About the previou smi_gen, we have gen1/gen2 that stand for the generation number for HW. I plan to add a new type(sub_common), then the "gen" is not prober. this patch only change it to "type", No functional change. Signed-off-by: Yong Wu ---