Re: [PATCH 6/6] arm64: document the choice of page attributes for pgprot_dmacoherent

2019-08-16 Thread Will Deacon
On Fri, Aug 16, 2019 at 07:59:42PM +0200, Christoph Hellwig wrote: > On Fri, Aug 16, 2019 at 06:31:18PM +0100, Will Deacon wrote: > > Mind if I tweak the second sentence to be: > > > > This is different from "Device-nGnR[nE]" memory which is intended for MMIO > > and thus forbids speculation,

Re: [PATCH 6/6] arm64: document the choice of page attributes for pgprot_dmacoherent

2019-08-16 Thread Christoph Hellwig
On Fri, Aug 16, 2019 at 06:31:18PM +0100, Will Deacon wrote: > Mind if I tweak the second sentence to be: > > This is different from "Device-nGnR[nE]" memory which is intended for MMIO > and thus forbids speculation, preserves access size, requires strict > alignment and can also force

Re: [PATCH 6/6] arm64: document the choice of page attributes for pgprot_dmacoherent

2019-08-16 Thread Mark Rutland
On Fri, Aug 16, 2019 at 06:31:18PM +0100, Will Deacon wrote: > Hi Christoph, > > Thanks for spinning this into a patch. > > On Fri, Aug 16, 2019 at 09:07:54AM +0200, Christoph Hellwig wrote: > > Based on an email from Will Deacon. > > > > Signed-off-by: Christoph Hellwig > > --- > >

Re: [PATCH 6/6] arm64: document the choice of page attributes for pgprot_dmacoherent

2019-08-16 Thread Will Deacon
Hi Christoph, Thanks for spinning this into a patch. On Fri, Aug 16, 2019 at 09:07:54AM +0200, Christoph Hellwig wrote: > Based on an email from Will Deacon. > > Signed-off-by: Christoph Hellwig > --- > arch/arm64/include/asm/pgtable.h | 8 > 1 file changed, 8 insertions(+) > > diff

[PATCH 6/6] arm64: document the choice of page attributes for pgprot_dmacoherent

2019-08-16 Thread Christoph Hellwig
Based on an email from Will Deacon. Signed-off-by: Christoph Hellwig --- arch/arm64/include/asm/pgtable.h | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h index 6700371227d1..6ff221d9a631 100644 ---