[PATCH 7/9] iommu/of: Use helper functions to access dev->iommu_fwspec

2018-12-11 Thread Joerg Roedel
From: Joerg Roedel Use the new helpers dev_iommu_fwspec_get()/set() to access the dev->iommu_fwspec pointer. This makes it easier to move that pointer later into another struct. Signed-off-by: Joerg Roedel --- drivers/iommu/of_iommu.c | 10 +++--- 1 file changed, 7 insertions(+), 3

Re: [PATCH 7/9] iommu/of: Use helper functions to access dev->iommu_fwspec

2018-12-06 Thread Joerg Roedel
On Wed, Dec 05, 2018 at 05:41:51PM +, Robin Murphy wrote: > Nit: I think it makes sense to put this inside the "if (!err)" condition > below rather than out here where it may or may not be relevant. The comment > for that case is already supposed to imply that it's dealing with a fresh >

Re: [PATCH 7/9] iommu/of: Use helper functions to access dev->iommu_fwspec

2018-12-05 Thread Robin Murphy
On 04/12/2018 16:30, Joerg Roedel wrote: From: Joerg Roedel Use the new helpers dev_iommu_fwspec_get()/set() to access the dev->iommu_fwspec pointer. This makes it easier to move that pointer later into another struct. Signed-off-by: Joerg Roedel --- drivers/iommu/of_iommu.c | 7 +--

[PATCH 7/9] iommu/of: Use helper functions to access dev->iommu_fwspec

2018-12-04 Thread Joerg Roedel
From: Joerg Roedel Use the new helpers dev_iommu_fwspec_get()/set() to access the dev->iommu_fwspec pointer. This makes it easier to move that pointer later into another struct. Signed-off-by: Joerg Roedel --- drivers/iommu/of_iommu.c | 7 +-- 1 file changed, 5 insertions(+), 2