RE: [PATCH V7 01/11] iommu/of: Refactor of_iommu_configure() for error handling

Hi Robin, >> I gave the whole patch set a try on ThunderX. really_probe() is failing >> on dma_configure()->of_pci_iommu_init() for each PCI device. > > When you say "failing", do you mean cleanly, or with a crash? I've > managed to hit __of_match_node() dereferencing NULL

Re: [PATCH V7 01/11] iommu/of: Refactor of_iommu_configure() for error handling

On 30/01/17 07:00, Sricharan wrote: > Hi Robin, > >>> [..] >>> >> +const struct iommu_ops *of_iommu_configure(struct device *dev, >> + struct device_node *master_np) >> +{ >> +const struct iommu_ops *ops; >> + >> +if (!master_np) >> +

RE: [PATCH V7 01/11] iommu/of: Refactor of_iommu_configure() for error handling

Hi Robin, >> [..] >> > +const struct iommu_ops *of_iommu_configure(struct device *dev, > + struct device_node *master_np) > +{ > +const struct iommu_ops *ops; > + > +if (!master_np) > +return NULL; > + > +if

Re: [PATCH V7 01/11] iommu/of: Refactor of_iommu_configure() for error handling

On 27/01/17 18:00, Sricharan wrote: > Hi Robin, > > [..] > +const struct iommu_ops *of_iommu_configure(struct device *dev, + struct device_node *master_np) +{ +const struct iommu_ops *ops; + +if (!master_np) +return NULL;

RE: [PATCH V7 01/11] iommu/of: Refactor of_iommu_configure() for error handling

Hi Robin, [..] >>> +const struct iommu_ops *of_iommu_configure(struct device *dev, >>> + struct device_node *master_np) >>> +{ >>> +const struct iommu_ops *ops; >>> + >>> +if (!master_np) >>> +return NULL; >>> + >>> +if (dev_is_pci(dev)) >>> +ops

Re: [PATCH V7 01/11] iommu/of: Refactor of_iommu_configure() for error handling

Hi Robin, On 25.01.2017 18:35, Robin Murphy wrote: Hi Tomasz, On 25/01/17 17:17, Tomasz Nowicki wrote: Hi Sricharan, On 23.01.2017 17:18, Sricharan R wrote: From: Robin Murphy In preparation for some upcoming cleverness, rework the control flow in

Re: [PATCH V7 01/11] iommu/of: Refactor of_iommu_configure() for error handling

Hi Tomasz, On 25/01/17 17:17, Tomasz Nowicki wrote: > Hi Sricharan, > > On 23.01.2017 17:18, Sricharan R wrote: >> From: Robin Murphy >> >> In preparation for some upcoming cleverness, rework the control flow in >> of_iommu_configure() to minimise duplication and improve

Re: [PATCH V7 01/11] iommu/of: Refactor of_iommu_configure() for error handling

Hi Sricharan, On 23.01.2017 17:18, Sricharan R wrote: From: Robin Murphy In preparation for some upcoming cleverness, rework the control flow in of_iommu_configure() to minimise duplication and improve the propogation of errors. It's also as good a time as any to switch

[PATCH V7 01/11] iommu/of: Refactor of_iommu_configure() for error handling

From: Robin Murphy In preparation for some upcoming cleverness, rework the control flow in of_iommu_configure() to minimise duplication and improve the propogation of errors. It's also as good a time as any to switch over from the now-just-a-compatibility-wrapper