Re: [PATCH v2] iommu/qcom: Fix local_base status check

2020-04-19 Thread Markus Elfring
> … >> +++ b/drivers/iommu/qcom_iommu.c >> @@ -813,8 +813,11 @@ static int qcom_iommu_device_probe(struct >> platform_device *pdev) >> qcom_iommu->dev = dev; >> >> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); … >> qcom_iommu->local_base = devm_ioremap_resource(dev,

Re: [PATCH v2] iommu/qcom: Fix local_base status check

2020-04-19 Thread Markus Elfring
> The function qcom_iommu_device_probe() does not perform sufficient > error checking after executing devm_ioremap_resource(), which can > result in crashes if a critical error path is encountered. Your update suggestion will be rechecked once more. * Can it be that the patch would need a higher

Re: [PATCH v2] iommu/qcom: Fix local_base status check

2020-04-03 Thread Markus Elfring
> Release resources when exiting on error. I have got doubts that such a change description fits to the proposed source code adjustment. … > +++ b/drivers/iommu/qcom_iommu.c > @@ -813,8 +813,11 @@ static int qcom_iommu_device_probe(struct > platform_device *pdev) > qcom_iommu->dev = dev;