Re: [PATCH v2]iommu/qcom:fix local_base status check

2020-05-01 Thread Tang Bin
On 2020/5/1 19:37, Joerg Roedel wrote: On Sat, Apr 18, 2020 at 09:47:03PM +0800, Tang Bin wrote: The function qcom_iommu_device_probe() does not perform sufficient error checking after executing devm_ioremap_resource(), which can result in crashes if a critical error path is encountered.

Re: [PATCH v2]iommu/qcom:fix local_base status check

2020-05-01 Thread Joerg Roedel
On Sat, Apr 18, 2020 at 09:47:03PM +0800, Tang Bin wrote: > The function qcom_iommu_device_probe() does not perform sufficient > error checking after executing devm_ioremap_resource(), which can > result in crashes if a critical error path is encountered. > > Fixes: 0ae349a0f33f ("iommu/qcom: Add

Re: [PATCH v2]iommu/qcom:fix local_base status check

2020-04-19 Thread Bjorn Andersson
On Sat 18 Apr 06:47 PDT 2020, Tang Bin wrote: > The function qcom_iommu_device_probe() does not perform sufficient > error checking after executing devm_ioremap_resource(), which can > result in crashes if a critical error path is encountered. > Thanks, that's much better. Reviewed-by: Bjorn

[PATCH v2]iommu/qcom:fix local_base status check

2020-04-18 Thread Tang Bin
The function qcom_iommu_device_probe() does not perform sufficient error checking after executing devm_ioremap_resource(), which can result in crashes if a critical error path is encountered. Fixes: 0ae349a0f33f ("iommu/qcom: Add qcom_iommu") Signed-off-by: Tang Bin --- v2: - fix commit