Re: [PATCH v2 08/11] iommu/vt-d: Fix indentation of goto labels

2022-02-24 Thread Lu Baolu
On 2/24/22 9:08 PM, Jason Gunthorpe wrote: On Mon, Feb 14, 2022 at 10:57:01AM +0800, Lu Baolu wrote: Remove blanks before goto labels. Signed-off-by: Lu Baolu drivers/iommu/intel/iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) It would be better to rework this function

Re: [PATCH v2 08/11] iommu/vt-d: Fix indentation of goto labels

2022-02-24 Thread Jason Gunthorpe via iommu
On Mon, Feb 14, 2022 at 10:57:01AM +0800, Lu Baolu wrote: > Remove blanks before goto labels. > > Signed-off-by: Lu Baolu > drivers/iommu/intel/iommu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) It would be better to rework this function to not have the goto spaghetti in the

Re: [PATCH v2 08/11] iommu/vt-d: Fix indentation of goto labels

2022-02-13 Thread Christoph Hellwig
On Mon, Feb 14, 2022 at 10:57:01AM +0800, Lu Baolu wrote: > Remove blanks before goto labels. The blanks are still pretty common in parts of the kernel, buf if you want them gone that sounds fine: Reviewed-by: Christoph Hellwig ___ iommu mailing list

[PATCH v2 08/11] iommu/vt-d: Fix indentation of goto labels

2022-02-13 Thread Lu Baolu
Remove blanks before goto labels. Signed-off-by: Lu Baolu --- drivers/iommu/intel/iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c index dfd3698406fa..d7fac0a1761d 100644 --- a/drivers/iommu/intel/iommu.c