Re: [PATCH v2 3/5] irqchip: Allow QCOM_PDC to be loadable as a permanent module

On Sat, 11 Jul 2020 00:27:45 +0100, Stephen Boyd wrote: > > Quoting John Stultz (2020-07-10 15:44:18) > > On Thu, Jul 9, 2020 at 11:02 PM Stephen Boyd wrote: > > > > > > Does it work? I haven't looked in detail but I worry that the child > > > irqdomain (i.e. pinctrl-msm) would need to delay

Re: [PATCH v2 3/5] irqchip: Allow QCOM_PDC to be loadable as a permanent module

Quoting John Stultz (2020-07-10 15:44:18) > On Thu, Jul 9, 2020 at 11:02 PM Stephen Boyd wrote: > > > > Does it work? I haven't looked in detail but I worry that the child > > irqdomain (i.e. pinctrl-msm) would need to delay probing until this > > parent irqdomain is registered. Or has the

Re: [PATCH v2 3/5] irqchip: Allow QCOM_PDC to be loadable as a permanent module

On Thu, Jul 9, 2020 at 11:02 PM Stephen Boyd wrote: > Quoting Marc Zyngier (2020-06-27 02:37:47) > > On Sat, 27 Jun 2020 02:34:25 +0100, > > John Stultz wrote: > > > > > > On Fri, Jun 26, 2020 at 12:42 AM Stephen Boyd wrote: > > > > > > > > > > > > Is there any reason to use IRQCHIP_DECLARE if

Re: [PATCH v2 3/5] irqchip: Allow QCOM_PDC to be loadable as a permanent module

Quoting Marc Zyngier (2020-06-27 02:37:47) > On Sat, 27 Jun 2020 02:34:25 +0100, > John Stultz wrote: > > > > On Fri, Jun 26, 2020 at 12:42 AM Stephen Boyd wrote: > > > > > > > > > Is there any reason to use IRQCHIP_DECLARE if this can work as a > > > platform device driver? > > > > > > > Hey!

Re: [PATCH v2 3/5] irqchip: Allow QCOM_PDC to be loadable as a permanent module

On Sat, 27 Jun 2020 02:34:25 +0100, John Stultz wrote: > > On Fri, Jun 26, 2020 at 12:42 AM Stephen Boyd wrote: > > > > Quoting John Stultz (2020-06-24 17:10:37) > > > diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c > > > index 6ae9e1f0819d..3fee8b655da1 100644 > > > ---

Re: [PATCH v2 3/5] irqchip: Allow QCOM_PDC to be loadable as a permanent module

On Fri, Jun 26, 2020 at 12:42 AM Stephen Boyd wrote: > > Quoting John Stultz (2020-06-24 17:10:37) > > diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c > > index 6ae9e1f0819d..3fee8b655da1 100644 > > --- a/drivers/irqchip/qcom-pdc.c > > +++ b/drivers/irqchip/qcom-pdc.c > > @@

Re: [PATCH v2 3/5] irqchip: Allow QCOM_PDC to be loadable as a permanent module

Quoting John Stultz (2020-06-24 17:10:37) > diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c > index 6ae9e1f0819d..3fee8b655da1 100644 > --- a/drivers/irqchip/qcom-pdc.c > +++ b/drivers/irqchip/qcom-pdc.c > @@ -430,4 +432,33 @@ static int qcom_pdc_init(struct device_node *node,

[PATCH v2 3/5] irqchip: Allow QCOM_PDC to be loadable as a permanent module

Allows qcom-pdc driver to be loaded as a permanent module Also, due to the fact that IRQCHIP_DECLARE becomes a no-op when building as a module, we have to add the platform driver hooks explicitly. Thanks to Saravana for his help on pointing out the IRQCHIP_DECLARE issue and guidance on a