Re: [PATCH v3 01/12] iommu/rockchip: Prohibiat unbind and remove

2018-01-18 Thread JeffyChen
Hi Tomasz, Thanks for your reply. and just found i forgot to add iommu clocks for other rockchip platforms(rk3399 already has that)...will also do that in the next version. On 01/18/2018 12:17 PM, Tomasz Figa wrote: On Thu, Jan 18, 2018 at 12:25 AM, Jeffy Chen

Re: [PATCH v3 01/12] iommu/rockchip: Prohibiat unbind and remove

2018-01-17 Thread Tomasz Figa
On Thu, Jan 18, 2018 at 12:25 AM, Jeffy Chen wrote: > Removal the IOMMUs cannot be done reliably. nit: Perhaps "Removal of IOMMUs"? > > This is similar to exynos iommu driver. > > Signed-off-by: Jeffy Chen > --- > > Changes in v3: > Also

[PATCH v3 01/12] iommu/rockchip: Prohibiat unbind and remove

2018-01-17 Thread Jeffy Chen
Removal the IOMMUs cannot be done reliably. This is similar to exynos iommu driver. Signed-off-by: Jeffy Chen --- Changes in v3: Also remove remove() and module_exit() as Tomasz suggested. Changes in v2: None drivers/iommu/rockchip-iommu.c | 21