Re: [PATCH v3 10/11] iommu/vt-d: Use device_domain_lock accurately

2022-07-02 Thread Baolu Lu
On 2022/7/1 16:15, Tian, Kevin wrote: From: Lu Baolu Sent: Wednesday, June 29, 2022 3:47 PM + spin_lock_irqsave(&device_domain_lock, flags); list_for_each_entry(info, &domain->devices, link) { - if (!info->dev) - continue; - suppose you can re

Re: [PATCH v3 10/11] iommu/vt-d: Use device_domain_lock accurately

2022-07-01 Thread Baolu Lu
On 2022/7/1 16:15, Tian, Kevin wrote: From: Lu Baolu Sent: Wednesday, June 29, 2022 3:47 PM + spin_lock_irqsave(&device_domain_lock, flags); list_for_each_entry(info, &domain->devices, link) { - if (!info->dev) - continue; - suppose you can re

RE: [PATCH v3 10/11] iommu/vt-d: Use device_domain_lock accurately

2022-07-01 Thread Tian, Kevin
> From: Lu Baolu > Sent: Wednesday, June 29, 2022 3:47 PM > > + spin_lock_irqsave(&device_domain_lock, flags); > list_for_each_entry(info, &domain->devices, link) { > - if (!info->dev) > - continue; > - suppose you can replace all spin_lock_irqsave() wit

[PATCH v3 10/11] iommu/vt-d: Use device_domain_lock accurately

2022-06-29 Thread Lu Baolu
The device_domain_lock is used to protect the device tracking list of a domain. Remove unnecessary spin_lock/unlock()'s and move the necessary ones around the list access. Signed-off-by: Lu Baolu --- drivers/iommu/intel/iommu.c | 61 ++--- 1 file changed, 23 inser