Re: [PATCH v4 03/38] iommu: add generic helper for mapping sgtable objects

2020-05-13 Thread Robin Murphy
On 2020-05-12 10:00 am, Marek Szyprowski wrote: struct sg_table is a common structure used for describing a memory buffer. It consists of a scatterlist with memory pages and DMA addresses (sgl entry), as well as the number of scatterlist entries: CPU pages (orig_nents entry) and DMA mapped pages

Re: [PATCH v4 03/38] iommu: add generic helper for mapping sgtable objects

2020-05-13 Thread Joerg Roedel
Hi Marek, On Tue, May 12, 2020 at 11:00:23AM +0200, Marek Szyprowski wrote: > --- > include/linux/iommu.h | 16 > 1 file changed, 16 insertions(+) Some nits below, with those fixed: Acked-by: Joerg Roedel > diff --git a/include/linux/iommu.h b/include/linux/iommu.h >

Re: [PATCH v4 03/38] iommu: add generic helper for mapping sgtable objects

2020-05-12 Thread Christoph Hellwig
On Tue, May 12, 2020 at 11:00:23AM +0200, Marek Szyprowski wrote: > struct sg_table is a common structure used for describing a memory > buffer. It consists of a scatterlist with memory pages and DMA addresses > (sgl entry), as well as the number of scatterlist entries: CPU pages > (orig_nents

[PATCH v4 03/38] iommu: add generic helper for mapping sgtable objects

2020-05-12 Thread Marek Szyprowski
struct sg_table is a common structure used for describing a memory buffer. It consists of a scatterlist with memory pages and DMA addresses (sgl entry), as well as the number of scatterlist entries: CPU pages (orig_nents entry) and DMA mapped pages (nents entry). It turned out that it was a