Re: [PATCH v4 17/22] iommu/vt-d: Avoid duplicated code for PASID setup

2019-07-16 Thread Auger Eric
Hi Jacob, On 6/9/19 3:44 PM, Jacob Pan wrote: > After each setup for PASID entry, related translation caches must be flushed. > We can combine duplicated code into one function which is less error prone. > > Signed-off-by: Jacob Pan > --- > drivers/iommu/intel-pasid.c | 48 >

Re: [PATCH v4 17/22] iommu/vt-d: Avoid duplicated code for PASID setup

2019-06-24 Thread Jacob Pan
On Tue, 18 Jun 2019 17:03:35 +0100 Jonathan Cameron wrote: > On Sun, 9 Jun 2019 06:44:17 -0700 > Jacob Pan wrote: > > > After each setup for PASID entry, related translation caches must > > be flushed. We can combine duplicated code into one function which > > is less error prone. > > > >

Re: [PATCH v4 17/22] iommu/vt-d: Avoid duplicated code for PASID setup

2019-06-18 Thread Jonathan Cameron
On Sun, 9 Jun 2019 06:44:17 -0700 Jacob Pan wrote: > After each setup for PASID entry, related translation caches must be flushed. > We can combine duplicated code into one function which is less error prone. > > Signed-off-by: Jacob Pan Formatting nitpick below ;) Otherwise it's cut and

[PATCH v4 17/22] iommu/vt-d: Avoid duplicated code for PASID setup

2019-06-09 Thread Jacob Pan
After each setup for PASID entry, related translation caches must be flushed. We can combine duplicated code into one function which is less error prone. Signed-off-by: Jacob Pan --- drivers/iommu/intel-pasid.c | 48 + 1 file changed, 18