Re: [PATCH v6 3/3] iommu/arm-smmu-v3:Enable ACPI based HiSilicon erratum 161010801

2017-09-07 Thread Lorenzo Pieralisi
On Tue, Sep 05, 2017 at 12:07:59PM +0100, John Garry wrote: > >> > >>Hi Will, Lorenzo, Robin, > >> > >>I have created the patch to add DT support for this erratum. > >>However, currently I have only added support for pci-based devices. > >>I'm a bit stumped on how to add platform device support,

Re: [PATCH v6 3/3] iommu/arm-smmu-v3:Enable ACPI based HiSilicon erratum 161010801

2017-09-05 Thread John Garry
Hi Will, Lorenzo, Robin, I have created the patch to add DT support for this erratum. However, currently I have only added support for pci-based devices. I'm a bit stumped on how to add platform device support, or if we should also add support at all. And I would rather ask before sending the

Re: [PATCH v6 3/3] iommu/arm-smmu-v3:Enable ACPI based HiSilicon erratum 161010801

2017-09-01 Thread John Garry
On 10/08/2017 18:27, Will Deacon wrote: On Wed, Aug 09, 2017 at 11:07:15AM +0100, Shameer Kolothum wrote: The HiSilicon erratum 161010801 describes the limitation of HiSilicon platforms Hip06/Hip07 to support the SMMU mappings for MSI transactions. On these platforms GICv3 ITS translator is

Re: [PATCH v6 3/3] iommu/arm-smmu-v3:Enable ACPI based HiSilicon erratum 161010801

2017-08-24 Thread John Garry
On 24/08/2017 15:35, Will Deacon wrote: > >>OK, seems reasonable. > >> > >>We would consider blacklisting the device, where/how to do is the question. > >> > >>So the errata is in the GICv3 ITS/PCI host controller, and we just use the > >>in-between SMMU (driver) to provide the workaround. So my

Re: [PATCH v6 3/3] iommu/arm-smmu-v3:Enable ACPI based HiSilicon erratum 161010801

2017-08-24 Thread Will Deacon
On Wed, Aug 23, 2017 at 05:55:52PM +0100, John Garry wrote: > On 23/08/2017 17:43, Will Deacon wrote: > >On Wed, Aug 23, 2017 at 03:29:46PM +0100, John Garry wrote: > >>On 23/08/2017 14:24, Will Deacon wrote: > >>>On Wed, Aug 23, 2017 at 02:17:24PM +0100, John Garry wrote: > >>>Signed-off-by:

Re: [PATCH v6 3/3] iommu/arm-smmu-v3:Enable ACPI based HiSilicon erratum 161010801

2017-08-23 Thread John Garry
On 23/08/2017 17:43, Will Deacon wrote: On Wed, Aug 23, 2017 at 03:29:46PM +0100, John Garry wrote: On 23/08/2017 14:24, Will Deacon wrote: On Wed, Aug 23, 2017 at 02:17:24PM +0100, John Garry wrote: Signed-off-by: Shameer Kolothum ---

Re: [PATCH v6 3/3] iommu/arm-smmu-v3:Enable ACPI based HiSilicon erratum 161010801

2017-08-23 Thread Will Deacon
On Wed, Aug 23, 2017 at 03:29:46PM +0100, John Garry wrote: > On 23/08/2017 14:24, Will Deacon wrote: > >On Wed, Aug 23, 2017 at 02:17:24PM +0100, John Garry wrote: > >Signed-off-by: Shameer Kolothum > > >--- > >drivers/iommu/arm-smmu-v3.c |

Re: [PATCH v6 3/3] iommu/arm-smmu-v3:Enable ACPI based HiSilicon erratum 161010801

2017-08-23 Thread John Garry
On 23/08/2017 14:24, Will Deacon wrote: On Wed, Aug 23, 2017 at 02:17:24PM +0100, John Garry wrote: Signed-off-by: Shameer Kolothum --- drivers/iommu/arm-smmu-v3.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) Please

Re: [PATCH v6 3/3] iommu/arm-smmu-v3:Enable ACPI based HiSilicon erratum 161010801

2017-08-23 Thread Will Deacon
On Wed, Aug 23, 2017 at 02:17:24PM +0100, John Garry wrote: > >>>Signed-off-by: Shameer Kolothum > >> > >>>--- > >>> drivers/iommu/arm-smmu-v3.c | 27 ++- > >>> 1 file changed, 22 insertions(+), 5 deletions(-) > >> > >>Please can you

Re: [PATCH v6 3/3] iommu/arm-smmu-v3:Enable ACPI based HiSilicon erratum 161010801

2017-08-23 Thread John Garry
Signed-off-by: Shameer Kolothum --- drivers/iommu/arm-smmu-v3.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) Please can you also add a devicetree binding with corresponding documentation to enable this workaround on

RE: [PATCH v6 3/3] iommu/arm-smmu-v3:Enable ACPI based HiSilicon erratum 161010801

2017-08-10 Thread Shameerali Kolothum Thodi
ro.org; > Gabriele Paoloni; John Garry; iommu@lists.linux-foundation.org; linux-arm- > ker...@lists.infradead.org; linux-a...@vger.kernel.org; de...@acpica.org; > Linuxarm; Wangzhou (B); Guohanjun (Hanjun Guo) > Subject: Re: [PATCH v6 3/3] iommu/arm-smmu-v3:Enable ACPI based > HiSili

Re: [PATCH v6 3/3] iommu/arm-smmu-v3:Enable ACPI based HiSilicon erratum 161010801

2017-08-10 Thread Will Deacon
On Wed, Aug 09, 2017 at 11:07:15AM +0100, Shameer Kolothum wrote: > The HiSilicon erratum 161010801 describes the limitation of HiSilicon > platforms Hip06/Hip07 to support the SMMU mappings for MSI transactions. > > On these platforms GICv3 ITS translator is presented with the deviceID > by

[PATCH v6 3/3] iommu/arm-smmu-v3:Enable ACPI based HiSilicon erratum 161010801

2017-08-09 Thread Shameer Kolothum
The HiSilicon erratum 161010801 describes the limitation of HiSilicon platforms Hip06/Hip07 to support the SMMU mappings for MSI transactions. On these platforms GICv3 ITS translator is presented with the deviceID by extending the MSI payload data to 64 bits to include the deviceID. Hence, the