Re: [PATCH v7 5/7] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver

2022-05-11 Thread James Clark
On 11/05/2022 03:02, liuqi (BA) wrote: > > Hi James, > > On 2022/5/10 18:14, James Clark wrote: >> >> >> On 07/04/2022 13:58, Yicong Yang wrote: >>> From: Qi Liu >>> > [...] >>>   struct auxtrace_record >>>   *auxtrace_record__init(struct evlist *evlist, int *err) >>>   { >>> @@ -57,8 +112,12

Re: [PATCH v7 5/7] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver

2022-05-10 Thread liuqi (BA) via iommu
Hi James, On 2022/5/10 18:14, James Clark wrote: On 07/04/2022 13:58, Yicong Yang wrote: From: Qi Liu [...] struct auxtrace_record *auxtrace_record__init(struct evlist *evlist, int *err) { @@ -57,8 +112,12 @@ struct auxtrace_record struct evsel *evsel; bool found_e

Re: [PATCH v7 5/7] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver

2022-05-10 Thread James Clark
On 07/04/2022 13:58, Yicong Yang wrote: > From: Qi Liu > > 'perf record' and 'perf report --dump-raw-trace' supported in this > patch. > > Example usage: > > Output will contain raw PTT data and its textual representation, such > as: > > 0 0 0x5810 [0x30]: PERF_RECORD_AUXTRACE size: 0x4

Re: [PATCH v7 5/7] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver

2022-05-05 Thread liuqi (BA) via iommu
Hi Leo, Thanks for your review, some replies below. On 2022/4/30 15:35, Leo Yan wrote: On Thu, Apr 07, 2022 at 08:58:39PM +0800, Yicong Yang via iommu wrote: From: Qi Liu 'perf record' and 'perf report --dump-raw-trace' supported in this patch. Example usage: Output will contain raw PTT

Re: [PATCH v7 5/7] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver

2022-04-30 Thread Leo Yan
On Thu, Apr 07, 2022 at 08:58:39PM +0800, Yicong Yang via iommu wrote: > From: Qi Liu > > 'perf record' and 'perf report --dump-raw-trace' supported in this > patch. > > Example usage: > > Output will contain raw PTT data and its textual representation, such > as: > > 0 0 0x5810 [0x30]: PERF_R

Re: [PATCH v7 5/7] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver

2022-04-14 Thread John Garry via iommu
On 12/04/2022 08:41, Yicong Yang wrote: +    hisi_ptt_pmus = zalloc(sizeof(struct perf_pmu *) * (*nr_ptts)); +    if (!hisi_ptt_pmus) { +    pr_err("hisi_ptt alloc failed\n"); +    *err = -ENOMEM; using PTR_ERR seems better, if possible ok will change to that. *err = -ENOMEM is used he

Re: [PATCH v7 5/7] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver

2022-04-12 Thread Yicong Yang via iommu
On 2022/4/12 1:19, John Garry wrote: > On 07/04/2022 13:58, Yicong Yang wrote: >> From: Qi Liu >> >> 'perf record' and 'perf report --dump-raw-trace' supported in this >> patch. >> >> Example usage: >> >> Output will contain raw PTT data and its textual representation, such >> as: >> >> 0 0 0x5810

Re: [PATCH v7 5/7] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver

2022-04-11 Thread John Garry via iommu
On 07/04/2022 13:58, Yicong Yang wrote: From: Qi Liu 'perf record' and 'perf report --dump-raw-trace' supported in this patch. Example usage: Output will contain raw PTT data and its textual representation, such as: 0 0 0x5810 [0x30]: PERF_RECORD_AUXTRACE size: 0x40 offset: 0 ref: 0xa5d

[PATCH v7 5/7] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver

2022-04-07 Thread Yicong Yang via iommu
From: Qi Liu 'perf record' and 'perf report --dump-raw-trace' supported in this patch. Example usage: Output will contain raw PTT data and its textual representation, such as: 0 0 0x5810 [0x30]: PERF_RECORD_AUXTRACE size: 0x40 offset: 0 ref: 0xa5d50c725 idx: 0 tid: -1 cpu: 0 . . ... HI