Re: [PATCH v8 05/13] iommu/amd: Add function copy_dev_tables()

2017-07-27 Thread Baoquan He
On 07/27/17 at 05:29pm, Joerg Roedel wrote: > On Fri, Jul 21, 2017 at 04:59:03PM +0800, Baoquan He wrote: > > Add function copy_dev_tables to copy the old DEV table entries of the > > panicked > > Since there is only one (for now), you can name the function in > singular: copy_dev_table() or copy

Re: [PATCH v8 05/13] iommu/amd: Add function copy_dev_tables()

2017-07-27 Thread Joerg Roedel
On Fri, Jul 21, 2017 at 04:59:03PM +0800, Baoquan He wrote: > Add function copy_dev_tables to copy the old DEV table entries of the panicked Since there is only one (for now), you can name the function in singular: copy_dev_table() or copy_device_table(). > kernel to the new allocated DEV table.

[PATCH v8 05/13] iommu/amd: Add function copy_dev_tables()

2017-07-21 Thread Baoquan He
Add function copy_dev_tables to copy the old DEV table entries of the panicked kernel to the new allocated DEV table. Since all iommus share the same DTE table the copy only need be done one time. Besides, we also need to: - Check whether all IOMMUs actually use the same device table with the sa