Re: [RFC PATCH 33/34] iommu: Remove add_device()/remove_device() code-paths

2020-04-14 Thread Joerg Roedel
Hi Marek, On Fri, Apr 10, 2020 at 12:39:38PM +0200, Marek Szyprowski wrote: > > + if (!group->default_domain) > > + continue; > > It doesn't look straight from the above diff, but this continue leaks > group->lock taken. You are right, thanks for the review! I fixed

Re: [RFC PATCH 33/34] iommu: Remove add_device()/remove_device() code-paths

2020-04-10 Thread Marek Szyprowski
Hi Joerg On 07.04.2020 20:37, Joerg Roedel wrote: > From: Joerg Roedel > > All drivers are converted to use the probe/release_device() > call-backs, so the add_device/remove_device() pointers are unused and > the code using them can be removed. > > Signed-off-by: Joerg Roedel > --- >

[RFC PATCH 33/34] iommu: Remove add_device()/remove_device() code-paths

2020-04-07 Thread Joerg Roedel
From: Joerg Roedel All drivers are converted to use the probe/release_device() call-backs, so the add_device/remove_device() pointers are unused and the code using them can be removed. Signed-off-by: Joerg Roedel --- drivers/iommu/iommu.c | 145 --