Re: [PATCH] Swiotlb: Add CONFIG_HAS_IOMEM check around memremap() in the swiotlb_mem_remap()

2022-01-04 Thread Wei Liu
On Tue, Jan 04, 2022 at 04:03:07PM +0100, Christoph Hellwig wrote: > On Tue, Jan 04, 2022 at 02:51:55PM +, Wei Liu wrote: > > > Please stub out all of swiotlb_mem_remap instead of the ifdef inside the > > > function. > > > > Does this look okay to you? > > Yes, thanks! Thanks for

Re: [PATCH] Swiotlb: Add CONFIG_HAS_IOMEM check around memremap() in the swiotlb_mem_remap()

2022-01-04 Thread Christoph Hellwig
On Tue, Jan 04, 2022 at 02:51:55PM +, Wei Liu wrote: > > Please stub out all of swiotlb_mem_remap instead of the ifdef inside the > > function. > > Does this look okay to you? Yes, thanks! ___ iommu mailing list iommu@lists.linux-foundation.org

Re: [PATCH] Swiotlb: Add CONFIG_HAS_IOMEM check around memremap() in the swiotlb_mem_remap()

2022-01-04 Thread Wei Liu
On Sun, Jan 02, 2022 at 11:54:46PM -0800, Christoph Hellwig wrote: > On Fri, Dec 31, 2021 at 11:56:40AM -0500, Tianyu Lan wrote: > > From: Tianyu Lan > > > > HAS_IOMEM option may not be selected on some platforms(e.g, s390) and this > > will cause compile error due to miss memremap()

Re: [PATCH] Swiotlb: Add CONFIG_HAS_IOMEM check around memremap() in the swiotlb_mem_remap()

2022-01-02 Thread Christoph Hellwig
On Fri, Dec 31, 2021 at 11:56:40AM -0500, Tianyu Lan wrote: > From: Tianyu Lan > > HAS_IOMEM option may not be selected on some platforms(e.g, s390) and this > will cause compile error due to miss memremap() implementation. Fix it via > adding HAS_IOMEM check around memremap() in the swiotlb.c.

Re: [PATCH] Swiotlb: Add CONFIG_HAS_IOMEM check around memremap() in the swiotlb_mem_remap()

2022-01-02 Thread Wei Liu
On Fri, Dec 31, 2021 at 11:56:40AM -0500, Tianyu Lan wrote: > From: Tianyu Lan > > HAS_IOMEM option may not be selected on some platforms(e.g, s390) and this > will cause compile error due to miss memremap() implementation. Fix it via miss -> missingk > adding HAS_IOMEM check around memremap()