Re: [PATCH] iommu/arm: Cleanup resources in case of probe error path

2021-07-01 Thread Marek Szyprowski
On 01.07.2021 11:11, Robin Murphy wrote: > On 2021-07-01 10:01, Will Deacon wrote: >> On Thu, Jul 01, 2021 at 10:29:29AM +0200, Marek Szyprowski wrote: >>> Hi Robin, >>> >>> On 30.06.2021 16:01, Robin Murphy wrote: On 2021-06-30 14:48, Marek Szyprowski wrote: > On 30.06.2021 14:59, Will

Re: [PATCH] iommu/arm: Cleanup resources in case of probe error path

2021-07-01 Thread Robin Murphy
On 2021-07-01 10:01, Will Deacon wrote: On Thu, Jul 01, 2021 at 10:29:29AM +0200, Marek Szyprowski wrote: Hi Robin, On 30.06.2021 16:01, Robin Murphy wrote: On 2021-06-30 14:48, Marek Szyprowski wrote: On 30.06.2021 14:59, Will Deacon wrote: On Wed, Jun 30, 2021 at 02:48:15PM +0200, Marek

Re: [PATCH] iommu/arm: Cleanup resources in case of probe error path

2021-07-01 Thread Will Deacon
On Thu, Jul 01, 2021 at 10:29:29AM +0200, Marek Szyprowski wrote: > Hi Robin, > > On 30.06.2021 16:01, Robin Murphy wrote: > > On 2021-06-30 14:48, Marek Szyprowski wrote: > >> On 30.06.2021 14:59, Will Deacon wrote: > >>> On Wed, Jun 30, 2021 at 02:48:15PM +0200, Marek Szyprowski wrote: >

Re: [PATCH] iommu/arm: Cleanup resources in case of probe error path

2021-07-01 Thread Marek Szyprowski
Hi Robin, On 30.06.2021 16:01, Robin Murphy wrote: > On 2021-06-30 14:48, Marek Szyprowski wrote: >> On 30.06.2021 14:59, Will Deacon wrote: >>> On Wed, Jun 30, 2021 at 02:48:15PM +0200, Marek Szyprowski wrote: On 08.06.2021 18:45, Amey Narkhede wrote: > If device registration fails,

RE: [PATCH] iommu/arm: Cleanup resources in case of probe error path

2021-06-30 Thread Krishna Reddy
> + > +err_pm_disable: > + pm_runtime_disable(dev); > return ret; > } Should it be pm_runtime_force_suspend()? qcom_iommu_device_remove() doesn't use pm_runtime_disable(dev). 875 static int qcom_iommu_device_remove(struct platform_device *pdev) 876 { ... 881

Re: [PATCH] iommu/arm: Cleanup resources in case of probe error path

2021-06-30 Thread Robin Murphy
On 2021-06-30 14:48, Marek Szyprowski wrote: On 30.06.2021 14:59, Will Deacon wrote: On Wed, Jun 30, 2021 at 02:48:15PM +0200, Marek Szyprowski wrote: On 08.06.2021 18:45, Amey Narkhede wrote: If device registration fails, remove sysfs attribute and if setting bus callbacks fails, unregister

Re: [PATCH] iommu/arm: Cleanup resources in case of probe error path

2021-06-30 Thread Marek Szyprowski
On 30.06.2021 14:59, Will Deacon wrote: > On Wed, Jun 30, 2021 at 02:48:15PM +0200, Marek Szyprowski wrote: >> On 08.06.2021 18:45, Amey Narkhede wrote: >>> If device registration fails, remove sysfs attribute >>> and if setting bus callbacks fails, unregister the device >>> and cleanup the sysfs

Re: [PATCH] iommu/arm: Cleanup resources in case of probe error path

2021-06-30 Thread Will Deacon
On Wed, Jun 30, 2021 at 02:48:15PM +0200, Marek Szyprowski wrote: > On 08.06.2021 18:45, Amey Narkhede wrote: > > If device registration fails, remove sysfs attribute > > and if setting bus callbacks fails, unregister the device > > and cleanup the sysfs attribute. > > > > Signed-off-by: Amey

Re: [PATCH] iommu/arm: Cleanup resources in case of probe error path

2021-06-30 Thread Marek Szyprowski
Hi, On 08.06.2021 18:45, Amey Narkhede wrote: > If device registration fails, remove sysfs attribute > and if setting bus callbacks fails, unregister the device > and cleanup the sysfs attribute. > > Signed-off-by: Amey Narkhede This patch landed in linux-next some time ago as commit

Re: [PATCH] iommu/arm: Cleanup resources in case of probe error path

2021-06-08 Thread Will Deacon
On Tue, 8 Jun 2021 22:15:59 +0530, Amey Narkhede wrote: > If device registration fails, remove sysfs attribute > and if setting bus callbacks fails, unregister the device > and cleanup the sysfs attribute. Applied to will (for-joerg/arm-smmu/updates), thanks! [1/1] iommu/arm: Cleanup resources