Re: [PATCH] iommu/dma: limit iova free size to unmmaped iova

2020-06-03 Thread guptap
On 2020-06-02 18:37, Robin Murphy wrote: On 2020-05-26 08:19, gup...@codeaurora.org wrote: On 2020-05-22 14:54, Robin Murphy wrote: On 2020-05-22 07:25, gup...@codeaurora.org wrote: On 2020-05-22 01:46, Robin Murphy wrote: On 2020-05-21 12:30, Prakash Gupta wrote: Sorry for delayed

Re: [PATCH] iommu/dma: limit iova free size to unmmaped iova

2020-06-02 Thread Robin Murphy
On 2020-05-26 08:19, gup...@codeaurora.org wrote: On 2020-05-22 14:54, Robin Murphy wrote: On 2020-05-22 07:25, gup...@codeaurora.org wrote: On 2020-05-22 01:46, Robin Murphy wrote: On 2020-05-21 12:30, Prakash Gupta wrote: I agree, we shouldn't be freeing the partial iova. Instead just

Re: [PATCH] iommu/dma: limit iova free size to unmmaped iova

2020-06-02 Thread guptap
On 2020-05-26 12:49, gup...@codeaurora.org wrote: On 2020-05-22 14:54, Robin Murphy wrote: On 2020-05-22 07:25, gup...@codeaurora.org wrote: On 2020-05-22 01:46, Robin Murphy wrote: On 2020-05-21 12:30, Prakash Gupta wrote: I agree, we shouldn't be freeing the partial iova. Instead just

Re: [PATCH] iommu/dma: limit iova free size to unmmaped iova

2020-05-26 Thread guptap
On 2020-05-22 14:54, Robin Murphy wrote: On 2020-05-22 07:25, gup...@codeaurora.org wrote: On 2020-05-22 01:46, Robin Murphy wrote: On 2020-05-21 12:30, Prakash Gupta wrote: I agree, we shouldn't be freeing the partial iova. Instead just making sure if unmap was successful should be

Re: [PATCH] iommu/dma: limit iova free size to unmmaped iova

2020-05-25 Thread Joerg Roedel
On Thu, May 21, 2020 at 11:49:06AM -0700, Andrew Morton wrote: > I'll assume that Joerg will handle this fix? Yes, I will when it turns out necessary. Regards, Joerg ___ iommu mailing list iommu@lists.linux-foundation.org

Re: [PATCH] iommu/dma: limit iova free size to unmmaped iova

2020-05-22 Thread Robin Murphy
On 2020-05-22 07:25, gup...@codeaurora.org wrote: On 2020-05-22 01:46, Robin Murphy wrote: On 2020-05-21 12:30, Prakash Gupta wrote: Limit the iova size while freeing based on unmapped size. In absence of this even with unmap failure, invalid iova is pushed to iova rcache and subsequently can

Re: [PATCH] iommu/dma: limit iova free size to unmmaped iova

2020-05-22 Thread guptap
On 2020-05-22 01:46, Robin Murphy wrote: On 2020-05-21 12:30, Prakash Gupta wrote: Limit the iova size while freeing based on unmapped size. In absence of this even with unmap failure, invalid iova is pushed to iova rcache and subsequently can cause panic while rcache magazine is freed. Can

Re: [PATCH] iommu/dma: limit iova free size to unmmaped iova

2020-05-21 Thread Robin Murphy
On 2020-05-21 12:30, Prakash Gupta wrote: Limit the iova size while freeing based on unmapped size. In absence of this even with unmap failure, invalid iova is pushed to iova rcache and subsequently can cause panic while rcache magazine is freed. Can you elaborate on that panic?

Re: [PATCH] iommu/dma: limit iova free size to unmmaped iova

2020-05-21 Thread Andrew Morton
On Thu, 21 May 2020 17:00:04 +0530 Prakash Gupta wrote: > Limit the iova size while freeing based on unmapped size. In absence of > this even with unmap failure, invalid iova is pushed to iova rcache and > subsequently can cause panic while rcache magazine is freed. > > Signed-off-by: Prakash