On 3/30/2019 3:15 AM, Jann Horn wrote:
On Fri, Mar 29, 2019 at 9:19 AM Mukesh Ojha wrote:
On 3/29/2019 4:29 AM, Jann Horn wrote:
The sparse checker attempts to ensure that all conversions between
fixed-endianness numbers and numbers with native endianness are explicit.
However, the calgary
On Fri, Mar 29, 2019 at 9:19 AM Mukesh Ojha wrote:
> On 3/29/2019 4:29 AM, Jann Horn wrote:
> > The sparse checker attempts to ensure that all conversions between
> > fixed-endianness numbers and numbers with native endianness are explicit.
> > However, the calgary code reads and writes
On 2019-03-29 3:40 p.m., Jann Horn wrote:
> So what is the right thing to do in the context of
> arch/x86/kernel/pci-calgary_64.c? That code wants to perform MMIO with
> endianness conversion, and these accesses are always performed as
> MMIO. Using the non-atomic 64-bit I/O helpers for this
On Fri, Mar 29, 2019 at 10:32 PM Logan Gunthorpe wrote:
> On 2019-03-29 3:19 p.m., Jann Horn wrote:
> >>> Can the existing api's not be used here like iowrite64be/ioread64be/ or
> >>> similar variant in "include/asm-generic/io.h"
> >>
> >> Oooh! I didn't realize that those exist. I'll change that
On 2019-03-29 3:19 p.m., Jann Horn wrote:
>>> Can the existing api's not be used here like iowrite64be/ioread64be/ or
>>> similar variant in "include/asm-generic/io.h"
>>
>> Oooh! I didn't realize that those exist. I'll change that and send a v2.
Yes, they are very new! It took me a while to
On Fri, Mar 29, 2019 at 10:19 PM Jann Horn wrote:
>
> +Logan Gunthorpe and Horia Geantă, since they've written a bunch of this code
>
> On Fri, Mar 29, 2019 at 5:48 PM Jann Horn wrote:
> > On Fri, Mar 29, 2019 at 9:19 AM Mukesh Ojha wrote:
> > > On 3/29/2019 4:29 AM, Jann Horn wrote:
> > > >
+Logan Gunthorpe and Horia Geantă, since they've written a bunch of this code
On Fri, Mar 29, 2019 at 5:48 PM Jann Horn wrote:
> On Fri, Mar 29, 2019 at 9:19 AM Mukesh Ojha wrote:
> > On 3/29/2019 4:29 AM, Jann Horn wrote:
> > > The sparse checker attempts to ensure that all conversions between
On Fri, Mar 29, 2019 at 9:19 AM Mukesh Ojha wrote:
> On 3/29/2019 4:29 AM, Jann Horn wrote:
> > The sparse checker attempts to ensure that all conversions between
> > fixed-endianness numbers and numbers with native endianness are explicit.
> > However, the calgary code reads and writes
On 3/29/2019 4:29 AM, Jann Horn wrote:
The sparse checker attempts to ensure that all conversions between
fixed-endianness numbers and numbers with native endianness are explicit.
However, the calgary code reads and writes big-endian numbers from/to IO
memory using {read,write}{l,q}(), which
