Re: new SBus related DMA warnings in 4.18+git

2018-08-28 Thread Christoph Hellwig
On Wed, Aug 29, 2018 at 08:47:04AM +0300, Meelis Roos wrote: > > Updated version including that has survived contact with a sparc cross > > compiler below. Note that this is on top of the previous patch adding > > a dma_mask to struct platform_device, which I've included as well. > > Works

Re: new SBus related DMA warnings in 4.18+git

2018-08-28 Thread Meelis Roos
> Updated version including that has survived contact with a sparc cross > compiler below. Note that this is on top of the previous patch adding > a dma_mask to struct platform_device, which I've included as well. Works completely fine on both Ultra 1 and Ultra 2 - nothing DMA-relaated in

Re: new SBus related DMA warnings in 4.18+git

2018-08-28 Thread Christoph Hellwig
Updated version including that has survived contact with a sparc cross compiler below. Note that this is on top of the previous patch adding a dma_mask to struct platform_device, which I've included as well. >From e22d27b9bf48c0e3d6eb106f596972c9357ed24d Mon Sep 17 00:00:00 2001 From: Christoph

Re: new SBus related DMA warnings in 4.18+git

2018-08-28 Thread Meelis Roos
> Based on the other thread here is a new attempt: CC arch/sparc/kernel/of_device_64.o arch/sparc/kernel/of_device_64.c: In function ‘scan_one_device’: arch/sparc/kernel/of_device_64.c:678:2: error: implicit declaration of function ‘DMA_BIT_MASK’ [-Werror=implicit-function-declaration]

Re: new SBus related DMA warnings in 4.18+git

2018-08-28 Thread Christoph Hellwig
On Mon, Aug 27, 2018 at 10:04:58PM +0300, Meelis Roos wrote: > > On Sun, Aug 26, 2018 at 10:48:44AM +0300, Meelis Roos wrote: > > > Tried yesterdays git 4.18.0-12789-gaa5b105 on a Sun Ultra 1 with SBus > > > and several SBus connected devicess give DMA mapping related warnings: > > > > This

Re: new SBus related DMA warnings in 4.18+git

2018-08-28 Thread Christoph Hellwig
On Mon, Aug 27, 2018 at 01:41:36PM -0700, David Miller wrote: > From: Sam Ravnborg > Date: Mon, 27 Aug 2018 21:15:18 +0200 > > > Why not fix the drivers rather than papering over the fact > > that they are missing the DMA mask? > > > > We are in the lucky situation the Meelis can test any

Re: new SBus related DMA warnings in 4.18+git

2018-08-27 Thread David Miller
From: Sam Ravnborg Date: Mon, 27 Aug 2018 21:15:18 +0200 > Why not fix the drivers rather than papering over the fact > that they are missing the DMA mask? > > We are in the lucky situation the Meelis can test any patches. SBUS drivers never set the mask because they never needed to and could

Re: new SBus related DMA warnings in 4.18+git

2018-08-27 Thread Sam Ravnborg
Hi Christoph. On Mon, Aug 27, 2018 at 05:47:16PM +0200, Christoph Hellwig wrote: > On Sun, Aug 26, 2018 at 10:48:44AM +0300, Meelis Roos wrote: > > Tried yesterdays git 4.18.0-12789-gaa5b105 on a Sun Ultra 1 with SBus > > and several SBus connected devicess give DMA mapping related warnings: >

Re: new SBus related DMA warnings in 4.18+git

2018-08-27 Thread Meelis Roos
> On Sun, Aug 26, 2018 at 10:48:44AM +0300, Meelis Roos wrote: > > Tried yesterdays git 4.18.0-12789-gaa5b105 on a Sun Ultra 1 with SBus > > and several SBus connected devicess give DMA mapping related warnings: > > This should have been around since the warning was added. > > The patch below

Re: new SBus related DMA warnings in 4.18+git

2018-08-27 Thread Christoph Hellwig
On Sun, Aug 26, 2018 at 10:48:44AM +0300, Meelis Roos wrote: > Tried yesterdays git 4.18.0-12789-gaa5b105 on a Sun Ultra 1 with SBus > and several SBus connected devicess give DMA mapping related warnings: This should have been around since the warning was added. The patch below should fix it: