Re: iommu/amd: Implement dm_region call-backs

2015-06-11 Thread Joerg Roedel
On Thu, Jun 11, 2015 at 11:02:51AM +0300, Dan Carpenter wrote: > On Thu, Jun 11, 2015 at 09:43:27AM +0200, Joerg Roedel wrote: > > What static checker do you use, btw? > > I'm using Smatch. > > The ERR_PTR stuff requires that you run > > smatch_scripts/build_kernel_data.sh > > At the star

Re: iommu/amd: Implement dm_region call-backs

2015-06-11 Thread Dan Carpenter
On Thu, Jun 11, 2015 at 09:43:27AM +0200, Joerg Roedel wrote: > On Wed, Jun 10, 2015 at 06:39:20PM +0300, Dan Carpenter wrote: > > Hello Joerg Roedel, > > > > The patch b61238c4a5e1: "iommu/amd: Implement dm_region call-backs" > > from May 28, 2015, leads to the following static checker warning: >

Re: iommu/amd: Implement dm_region call-backs

2015-06-11 Thread Joerg Roedel
On Wed, Jun 10, 2015 at 06:39:20PM +0300, Dan Carpenter wrote: > Hello Joerg Roedel, > > The patch b61238c4a5e1: "iommu/amd: Implement dm_region call-backs" > from May 28, 2015, leads to the following static checker warning: > > drivers/iommu/amd_iommu.c:3153 amd_iommu_get_dm_regions() >

re: iommu/amd: Implement dm_region call-backs

2015-06-10 Thread Dan Carpenter
Hello Joerg Roedel, The patch b61238c4a5e1: "iommu/amd: Implement dm_region call-backs" from May 28, 2015, leads to the following static checker warning: drivers/iommu/amd_iommu.c:3153 amd_iommu_get_dm_regions() error: potential null dereference 'region'. (kzalloc returns null)