Re: revert dma direct internals abuse

2019-04-23 Thread Thomas Hellstrom via iommu
Hi, Christoph, On Mon, 2019-04-22 at 19:56 +0200, h...@lst.de wrote: > On Wed, Apr 10, 2019 at 03:01:14PM +, Thomas Hellstrom wrote: > > > So can you please respin a version acceptable to you and submit > > > it > > > for 5.1 ASAP? Otherwise I'll need to move ahead with the simple > > >

Re: revert dma direct internals abuse

2019-04-22 Thread h...@lst.de
On Wed, Apr 10, 2019 at 03:01:14PM +, Thomas Hellstrom wrote: > > So can you please respin a version acceptable to you and submit it > > for 5.1 ASAP? Otherwise I'll need to move ahead with the simple > > revert. > > I will. > I need to do some testing to investigate how to best choose

Re: revert dma direct internals abuse

2019-04-10 Thread Thomas Hellstrom via iommu
On Wed, 2019-04-10 at 08:43 +0200, h...@lst.de wrote: > On Tue, Apr 09, 2019 at 05:24:48PM +, Thomas Hellstrom wrote: > > > Note that this only affects external, untrusted devices. But > > > that > > > may include eGPU, > > > > What about discrete graphics cards, like Radeon and Nvidia? Who

Re: revert dma direct internals abuse

2019-04-10 Thread h...@lst.de
On Tue, Apr 09, 2019 at 05:24:48PM +, Thomas Hellstrom wrote: > > Note that this only affects external, untrusted devices. But that > > may include eGPU, > > What about discrete graphics cards, like Radeon and Nvidia? Who gets to > determine what's trusted? Based on firmware tables.

Re: revert dma direct internals abuse

2019-04-09 Thread Thomas Hellstrom via iommu
On Tue, 2019-04-09 at 17:25 +0200, h...@lst.de wrote: > On Tue, Apr 09, 2019 at 02:17:40PM +, Thomas Hellstrom wrote: > > If that's the case, I think most of the graphics drivers will stop > > functioning. I don't think people would want that, and even if the > > graphics drivers are "to

Re: revert dma direct internals abuse

2019-04-09 Thread h...@lst.de
On Tue, Apr 09, 2019 at 02:17:40PM +, Thomas Hellstrom wrote: > If that's the case, I think most of the graphics drivers will stop > functioning. I don't think people would want that, and even if the > graphics drivers are "to blame" due to not implementing the sync calls, > I think the work

Re: revert dma direct internals abuse

2019-04-09 Thread Thomas Hellstrom via iommu
On Tue, 2019-04-09 at 15:31 +0200, h...@lst.de wrote: > On Tue, Apr 09, 2019 at 01:04:51PM +, Thomas Hellstrom wrote: > > On the VMware platform we have two possible vIOMMUS, the AMD iommu > > and > > Intel VTD, Given those conditions I belive the patch is > > functionally > > correct. We

Re: revert dma direct internals abuse

2019-04-09 Thread h...@lst.de
On Tue, Apr 09, 2019 at 01:04:51PM +, Thomas Hellstrom wrote: > On the VMware platform we have two possible vIOMMUS, the AMD iommu and > Intel VTD, Given those conditions I belive the patch is functionally > correct. We can't cover the AMD case with intel_iommu_enabled. > Furthermore the only

Re: revert dma direct internals abuse

2019-04-09 Thread Thomas Hellstrom via iommu
On Tue, 2019-04-09 at 11:57 +0200, h...@lst.de wrote: > On Mon, Apr 08, 2019 at 06:47:52PM +, Thomas Hellstrom wrote: > > We HAVE discussed our needs, although admittedly some of my emails > > ended up unanswered. > > And than you haven't followed up, and instead ignored the layering >

Re: revert dma direct internals abuse

2019-04-09 Thread h...@lst.de
On Mon, Apr 08, 2019 at 06:47:52PM +, Thomas Hellstrom wrote: > We HAVE discussed our needs, although admittedly some of my emails > ended up unanswered. And than you haven't followed up, and instead ignored the layering instructions and just commited a broken patch? > We've as you're well

Re: revert dma direct internals abuse

2019-04-08 Thread Thomas Hellstrom via iommu
Christoph, On Mon, 2019-04-08 at 12:55 +0200, Christoph Hellwig wrote: > Hi Linus, > > unfortunately it took less than a merge window for the: > > /* > * All the dma_direct_* declarations are here just for the indirect > call bypass, > * and must not be used directly drivers! > */ > >

revert dma direct internals abuse

2019-04-08 Thread Christoph Hellwig
Hi Linus, unfortunately it took less than a merge window for the: /* * All the dma_direct_* declarations are here just for the indirect call bypass, * and must not be used directly drivers! */ warning in dma-mapping.h to be ignored. This series reverts the offender to keep our API clean.